You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/05/05 02:29:43 UTC
Review Request 33831: kerberos-env/kdc_type must not be mandatory if
kerberos-env/manage_identities is false.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33831/
-----------------------------------------------------------
Review request for Ambari, Emil Anca and Vitalyi Brodetskyi.
Bugs: AMBARI-10900
https://issues.apache.org/jira/browse/AMBARI-10900
Repository: ambari
Description
-------
kerberos-env/kdc_type must not be mandatory if kerberos-env/manage_identities is false.
**Solution**
Support kerberos-env/kdc-type of "none", "", or `null` when kerberos-env/manage_identities is "false".
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 5da61c1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java 57b267d
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java af13ecc
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KDCTypeTest.java 2c6366f
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 2751b21
Diff: https://reviews.apache.org/r/33831/diff/
Testing
-------
Manually tested in cluser
Updated init tests
**Jenkins test results: PENDING**
Thanks,
Robert Levas
Re: Review Request 33831: kerberos-env/kdc_type must not be mandatory
if kerberos-env/manage_identities is false.
Posted by Emil Anca <ea...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33831/#review82499
-----------------------------------------------------------
Ship it!
Ship It!
- Emil Anca
On May 5, 2015, 12:29 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33831/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 12:29 a.m.)
>
>
> Review request for Ambari, Emil Anca and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-10900
> https://issues.apache.org/jira/browse/AMBARI-10900
>
>
> Repository: ambari
>
>
> Description
> -------
>
> kerberos-env/kdc_type must not be mandatory if kerberos-env/manage_identities is false.
>
> **Solution**
> Support kerberos-env/kdc-type of "none", "", or `null` when kerberos-env/manage_identities is "false".
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 5da61c1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java 57b267d
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java af13ecc
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KDCTypeTest.java 2c6366f
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactoryTest.java 2751b21
>
> Diff: https://reviews.apache.org/r/33831/diff/
>
>
> Testing
> -------
>
> Manually tested in cluser
> Updated init tests
>
> **Jenkins test results: PENDING**
>
>
> Thanks,
>
> Robert Levas
>
>