You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2021/07/20 20:50:12 UTC

[Impala-ASF-CR] IMPALA-8762: Track host level admission stats across all coordinators

Hello Andrew Sherman, Joe McDonnell, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17683

to look at the new patch set (#2).

Change subject: IMPALA-8762: Track host level admission stats across all coordinators
......................................................................

IMPALA-8762: Track host level admission stats across all coordinators

This patch adds the ability to share the per-host stats for locally
admitted queries across all coordinators. This helps to get a more
consolidated view of the cluster for stats like slots_in_use and
mem_admitted when making local admission decisions.

Testing:
Added e2e py test

Change-Id: I2946832e0a89b077d0f3bec755e4672be2088243
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M common/thrift/StatestoreService.thrift
M common/thrift/metrics.json
M tests/common/custom_cluster_test_suite.py
M tests/custom_cluster/test_catalog_wait.py
M tests/custom_cluster/test_executor_groups.py
M tests/custom_cluster/test_runtime_profile.py
M tests/custom_cluster/test_scratch_disk.py
9 files changed, 261 insertions(+), 86 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/17683/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2946832e0a89b077d0f3bec755e4672be2088243
Gerrit-Change-Number: 17683
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>