You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/13 12:32:09 UTC
[GitHub] [incubator-tvm] bernhardklein opened a new pull request #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
bernhardklein opened a new pull request #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063
Hello together,
since last changes I had a issue compiling stuff for my ARM CPUs( Rasberry Pi 3b+). I got the error message that stride_h is not known. Seems understandable in the code, so I guess that the required assumption here is to strict. It seems to work well with removed stride assumption. However, the original authors of this code can you take a look and check if I am right.
Thanks, Bernhard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] bernhardklein commented on issue #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on issue #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063#issuecomment-599567924
@FrozenGene Thank you for your response. I think the assumption a view lines obove `assert strides == (1, 1), "Do not support strides now"` already ensures that stride is 1. A second check should be unnecessary. Correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063#issuecomment-599569907
> @FrozenGene Thank you for your response. I think the assumption a view lines obove `assert strides == (1, 1), "Do not support strides now"` already ensures that stride is 1. A second check should be unnecessary. Correct me if I'm wrong.
Yeah, you are correct! I didn't realize we assert here. Thanks for pointing it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063#issuecomment-599209511
I think the fix is not correct. Winograd doesn't support stride > 1. The issue here is we don't have code `stride_h, stride_w = strides` and just have `strides = attrs.get_int_tuple("strides")`. Please fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] icemelon9 commented on issue #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
icemelon9 commented on issue #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063#issuecomment-598924642
Thanks @bernhardklein. This is now merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] icemelon9 merged pull request #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
icemelon9 merged pull request #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] bernhardklein commented on issue #5063:
[Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
Posted by GitBox <gi...@apache.org>.
bernhardklein commented on issue #5063: [Relay][AutoTVM] Bug Fix for ARM CPUs. Lower strict assumption.
URL: https://github.com/apache/incubator-tvm/pull/5063#issuecomment-598699114
cc @icemelon9 @kevinthesun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services