You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/04/29 03:34:13 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #545: Add .asf.yaml file
tisonkun opened a new pull request, #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545
This closes #544.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#discussion_r861511219
##########
.asf.yaml:
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# For more information, see https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features.
+
+github:
+ description: >-
+ Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine
+ and is compatible with Redis protocol.
+ homepage: https://kvrocks.apache.org/
Review Comment:
I see almost all incubator projects doesn't have the `incubator` section. For example,
* https://inlong.apache.org/
* https://eventmesh.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#discussion_r861449617
##########
.asf.yaml:
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# For more information, see https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features.
+
+github:
+ description: >-
+ Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine
+ and is compatible with Redis protocol.
+ homepage: https://kvrocks.apache.org/
+ enabled_merge_buttons:
+ squash: true
+ merge: false
+ rebase: false
Review Comment:
```suggestion
rebase: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#issuecomment-1112859981
@ShooterIT merge button config applied on the whole repository. There is no branch level configure. But I'm OK to enable rebase and merge option as long as we keep linear history at unstable and release branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Hexiaoqiao commented on a diff in pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
Hexiaoqiao commented on code in PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#discussion_r861542565
##########
.asf.yaml:
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# For more information, see https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features.
+
+github:
+ description: >-
+ Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine
+ and is compatible with Redis protocol.
+ homepage: https://kvrocks.apache.org/
Review Comment:
Sure. According this guide(https://incubator.apache.org/guides/sites.html), both of them are accepted, and therefore some podlings point to p.incubator.a.o and others point to p.a.o.
LGTM. +1. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Hexiaoqiao commented on a diff in pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
Hexiaoqiao commented on code in PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#discussion_r861506950
##########
.asf.yaml:
##########
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# For more information, see https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features.
+
+github:
+ description: >-
+ Kvrocks is a distributed key value NoSQL database that uses RocksDB as storage engine
+ and is compatible with Redis protocol.
+ homepage: https://kvrocks.apache.org/
Review Comment:
I think we should use https://kvrocks.incubator.apache.org rather than https://kvrocks.apache.org/ when incubating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ShooterIT commented on pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
ShooterIT commented on PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#issuecomment-1112856826
On other branch, could we use `rebase` merge button?
I used `rebase` merge when I release new version, such as #468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #545: Add .asf.yaml file
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #545:
URL: https://github.com/apache/incubator-kvrocks/pull/545#issuecomment-1112850628
cc @git-hulk @Hexiaoqiao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org