You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2011/10/24 18:15:32 UTC
[jira] [Created] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Bookkeeper and hedwig clients should not use log4j directly
-----------------------------------------------------------
Key: BOOKKEEPER-91
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
Project: Bookkeeper
Issue Type: Improvement
Reporter: Ivan Kelly
Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
We should use something like commons logging[1] or slf4j[2].
[1] http://commons.apache.org/logging/index.html
[2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151326#comment-13151326 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-91:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2808/
-----------------------------------------------------------
(Updated 2011-11-16 16:55:05.131518)
Review request for bookkeeper.
Changes
-------
rebased to trunk@1202758
Summary
-------
Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
We should use something like commons logging[1] or slf4j[2].
[1] http://commons.apache.org/logging/index.html
[2] http://www.slf4j.org/
This addresses bug BOOKKEEPER-91.
https://issues.apache.org/jira/browse/BOOKKEEPER-91
Diffs (updated)
-----
bookkeeper-benchmark/pom.xml 3f905ae
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/MySqlClient.java ad5f445
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/TestClient.java 213763f
bookkeeper-server/pom.xml fd6cef6
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6140ee0
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 1fafac1
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java 7c4f250
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java 1aa3594
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 037c018
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 36c3bd1
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 883ccff
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java b2fbc6b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java 97552e6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 56b7a8c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 97b06fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java 8f65e1b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 9e0e95a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 30584bf
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 037e2e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java 5a898d9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java bbe7986
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java baa7209
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java c78bcf6
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java d7b25c5
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java 7876eb4
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java 5395acf
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 8d060cb
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java 911b539
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java bbde2fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java e15f0a4
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java 4e5b134
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/SafeRunnable.java b8284b8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java 39334af
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 1d498ee
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java 07639aa
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java 6614bc5
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 728c35d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java 581f3ad
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java 8dbae67
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 74b5d6f
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/CloseTest.java b43db91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConcurrentLedgerTest.java ebb17d2
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConditionalSetTest.java 0b04a91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 48d5e70
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerRecoveryTest.java 50cbfa9
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java c12c041
hedwig-client/pom.xml bab780a
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 0e87dd7
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 79acc96
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/HedwigBenchmark.java 643f6d9
hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java 52e5704
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java 2e11d63
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PubSubCallback.java 563ad65
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PublishResponseHandler.java 90e62ba
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeReconnectCallback.java 60388fa
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java 2256a68
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/UnsubscribeResponseHandler.java f12e476
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java 3f13754
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClient.java b270d34
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java e381107
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 7b21a4d
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ResponseHandler.java 378bb19
hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8cac77
hedwig-client/src/main/java/org/apache/hedwig/util/CallbackUtils.java c90e0e6
hedwig-client/src/main/java/org/apache/hedwig/util/FileUtils.java 98e41e1
hedwig-server/pom.xml b6d2e65
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/AbstractBenchmark.java cd2d65e
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookieBenchmark.java ff1462d
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java b3229a1
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/FakeBookie.java a394d05
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java 419b9b0
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java af3d12e
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java 2f510c8
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java cf56c73
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 5196a44
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java a6079df
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/CacheValue.java ef42009
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 84ebd62
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 31e9c06
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java f8b836a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConsumeHandler.java 8bbd68a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStartDeliveryHandler.java 07706c1
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStopDeliveryHandler.java 6f5eb20
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxySubscribeHandler.java 8112a5c
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java 9533d8c
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java bf320dd
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java b480fa0
hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 05562c9
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java e884d76
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java 8f0de63
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 125cd93
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java d320c6b
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 1e3d5dd
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 3ed363e
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java 3a079f2
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java e89dd4c
hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java 31b1dc1
Diff: https://reviews.apache.org/r/2808/diff
Testing
-------
Thanks,
Ivan
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff, BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143025#comment-13143025 ]
Ivan Kelly commented on BOOKKEEPER-91:
--------------------------------------
We should also write logging guidelines with this.
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-91:
---------------------------------
Attachment: BOOKKEEPER-91.diff
Rebased onto trunk@1202758
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff, BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Ivan Kelly (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly reassigned BOOKKEEPER-91:
------------------------------------
Assignee: Ivan Kelly
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148613#comment-13148613 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-91:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2808/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
We should use something like commons logging[1] or slf4j[2].
[1] http://commons.apache.org/logging/index.html
[2] http://www.slf4j.org/
This addresses bug BOOKKEEPER-91.
https://issues.apache.org/jira/browse/BOOKKEEPER-91
Diffs
-----
bookkeeper-benchmark/pom.xml 3f905ae
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/MySqlClient.java ad5f445
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/TestClient.java 213763f
bookkeeper-server/pom.xml fd6cef6
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java d651894
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 1410bc4
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java 7c4f250
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java 1aa3594
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 024cac3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java a1fbab7
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b3eb5b9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java b2fbc6b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java 97552e6
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 6f72e47
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 97b06fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java 8f65e1b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 8c2a54f
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 328c7ca
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java a68856c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java 7465c52
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java eddd760
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java 385b16c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java c2d4cee
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java d70ae27
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java f1b3ad9
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java e0743bb
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 2cd4de8
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java 911b539
bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java bbde2fb
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java e15f0a4
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java 4e5b134
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/SafeRunnable.java b8284b8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java 39334af
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java 07639aa
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java 6614bc5
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 6bac569
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java 97dc2ab
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java 8dbae67
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 74b5d6f
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieRecoveryTest.java ac54d9a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/CloseTest.java b43db91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConcurrentLedgerTest.java ebb17d2
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConditionalSetTest.java 0b04a91
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 48d5e70
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerRecoveryTest.java 50cbfa9
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java 85822bf
hedwig-client/pom.xml bab780a
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 0e87dd7
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 79acc96
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/HedwigBenchmark.java 643f6d9
hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java 52e5704
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java 2e11d63
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PubSubCallback.java 563ad65
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PublishResponseHandler.java 90e62ba
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeReconnectCallback.java 60388fa
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java 2256a68
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/UnsubscribeResponseHandler.java f12e476
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java 3f13754
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClient.java b270d34
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java e381107
hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java 7b21a4d
hedwig-client/src/main/java/org/apache/hedwig/client/netty/ResponseHandler.java 378bb19
hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java a8cac77
hedwig-client/src/main/java/org/apache/hedwig/util/CallbackUtils.java c90e0e6
hedwig-client/src/main/java/org/apache/hedwig/util/FileUtils.java 98e41e1
hedwig-server/pom.xml b6d2e65
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/AbstractBenchmark.java cd2d65e
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookieBenchmark.java 18319d7
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java b3229a1
hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/FakeBookie.java a394d05
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java 419b9b0
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java af3d12e
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java 2f510c8
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java cf56c73
hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java 5196a44
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java a6079df
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/CacheValue.java ef42009
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 84ebd62
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 31e9c06
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java f8b836a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConsumeHandler.java 8bbd68a
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStartDeliveryHandler.java 07706c1
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStopDeliveryHandler.java 6f5eb20
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxySubscribeHandler.java 8112a5c
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java 9533d8c
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java bf320dd
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java b480fa0
hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java 05562c9
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java e884d76
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java 8f0de63
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 125cd93
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java d320c6b
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 1e3d5dd
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 3ed363e
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java 3a079f2
hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java e89dd4c
hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java 31b1dc1
Diff: https://reviews.apache.org/r/2808/diff
Testing
-------
Thanks,
Ivan
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151988#comment-13151988 ]
Hudson commented on BOOKKEEPER-91:
----------------------------------
Integrated in bookkeeper-trunk #223 (See [https://builds.apache.org/job/bookkeeper-trunk/223/])
BOOKKEEPER-91: Bookkeeper and hedwig clients should not use log4j directly (ivank via fpj)
fpj :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/MySqlClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/TestClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookieWatcher.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/SafeRunnable.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/CloseTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConcurrentLedgerTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ConditionalSetTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerRecoveryTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java
* /zookeeper/bookkeeper/trunk/hedwig-client/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/HedwigBenchmark.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/conf/ClientConfiguration.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PubSubCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PublishResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeReconnectCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/UnsubscribeResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClient.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/ResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/CallbackUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/util/FileUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-server/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/AbstractBenchmark.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookieBenchmark.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/FakeBookie.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/handlers/SubscribeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/CacheValue.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConsumeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStartDeliveryHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyStopDeliveryHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxySubscribeHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/ZkSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/zookeeper/ZkUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/TestPersistenceManagerBlackBox.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff, BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-91:
---------------------------------
Attachment: BOOKKEEPER-91.diff
Patch switches bookkeeper+hedwig from log4j to slf4j.
I've reconsidered about needed specific logging guidelines for bookkeeper+hedwig. there's nothing special or interesting about how we log. There are plenty of general guides of what to put at each level on the slf4j site.
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-91) Bookkeeper and hedwig clients
should not use log4j directly
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151972#comment-13151972 ]
Flavio Junqueira commented on BOOKKEEPER-91:
--------------------------------------------
+1, thanks, Ivan! Committed revision 1203138.
> Bookkeeper and hedwig clients should not use log4j directly
> -----------------------------------------------------------
>
> Key: BOOKKEEPER-91
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-91.diff, BOOKKEEPER-91.diff
>
>
> Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j.
> We should use something like commons logging[1] or slf4j[2].
> [1] http://commons.apache.org/logging/index.html
> [2] http://www.slf4j.org/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira