You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/01/06 17:50:27 UTC
[kudu-CR] [tool] Add --host to start kudu.sh script
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18127
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
[tool] Add --host to start_kudu.sh script
Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18127/1
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18127
to look at the new patch set (#2).
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
[tool] Add --host to start_kudu.sh script
The start_kudu.sh script currently works with an assumption that the
Kudu servers will be accessed from the same host that they're running on
(i.e. localhost).
Recently, while running Kudu in a remote Linux box, I wanted to access
it from my, but the ports were bound to the loopback interface, so I
wasn't able to do that. This change makes it possible to change what
interface the servers bound to. To make sure the web server can be
connected to from both a remote machine and from localhost, this patch
also removes the --webserver_interface flag, which defaults to 0.0.0.0.
Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18127/2
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18127/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18127/2//COMMIT_MSG@14
PS2, Line 14: my
nit: missing a word?
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jan 2022 19:47:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18127/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18127/2//COMMIT_MSG@14
PS2, Line 14: my
> nit: missing a word?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jan 2022 19:50:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18127
to look at the new patch set (#3).
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
[tool] Add --host to start_kudu.sh script
The start_kudu.sh script currently works with an assumption that the
Kudu servers will be accessed from the same host that they're running on
(i.e. localhost).
Recently, while running Kudu in a remote Linux box, I wanted to access
it from my Mac, but the ports were bound to the loopback interface, so I
wasn't able to do that. This change makes it possible to change what
interface the servers bound to. To make sure the web server can be
connected to from both a remote machine and from localhost, this patch
also removes the --webserver_interface flag, which defaults to 0.0.0.0.
Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/18127/3
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18127/1//COMMIT_MSG
Commit Message:
PS1:
Curious what the motivation is here?
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh@a45
PS1, Line 45:
:
nit: update here too?
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh@a240
PS1, Line 240:
Any particular reason for removing these?
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jan 2022 18:12:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jan 2022 01:38:18 +0000
Gerrit-HasComments: No
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
[tool] Add --host to start_kudu.sh script
The start_kudu.sh script currently works with an assumption that the
Kudu servers will be accessed from the same host that they're running on
(i.e. localhost).
Recently, while running Kudu in a remote Linux box, I wanted to access
it from my Mac, but the ports were bound to the loopback interface, so I
wasn't able to do that. This change makes it possible to change what
interface the servers bound to. To make sure the web server can be
connected to from both a remote machine and from localhost, this patch
also removes the --webserver_interface flag, which defaults to 0.0.0.0.
Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Reviewed-on: http://gerrit.cloudera.org:8080/18127
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tool] Add --host to start kudu.sh script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18127 )
Change subject: [tool] Add --host to start_kudu.sh script
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18127/1//COMMIT_MSG
Commit Message:
PS1:
> Curious what the motivation is here?
Elaborated on this in the description.
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh@a45
PS1, Line 45:
:
> nit: update here too?
Done
http://gerrit.cloudera.org:8080/#/c/18127/1/src/kudu/scripts/start_kudu.sh@a240
PS1, Line 240:
> Any particular reason for removing these?
Explained it in the commit message too.
--
To view, visit http://gerrit.cloudera.org:8080/18127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68f920a03f494d277b5f7008b0a75cd927634d9f
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jan 2022 19:05:35 +0000
Gerrit-HasComments: Yes