[GitHub] [flink] zentol commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…

[GitBox <gi...@apache.org>]

zentol commented on issue #10247: [FLINK-14813][runtime]Expose the new mechanism implemented in FLINK-1…
URL: https://github.com/apache/flink/pull/10247#issuecomment-559565839
 
 
   I don't believe this PR should have been merged.
   
   There are multiple typos in method names of "user"-facing interfaces, it re-introduces the concept of tasks into the ShuffleEnvironment _that we just removed_, the metric should not have access to the _entire_ Task class, the metric _maybe_ should be a numeric value (1/0) to support more metric backends.
   I'm also a bit surprised that the shuffle service has to access a mechanism from the task to figure out whether it is back-pressured or not. Seems like it's not part of the shuffle service, making me wonder why we're pushing the metric into the shuffle service.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services