You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2017/02/07 17:31:30 UTC
[GitHub] incubator-quickstep pull request #183: Adds regex to specify 16.+ versions o...
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/183
Adds regex to specify 16.+ versions of Darwin
Before this change, only one recent version of Darwin was correctly
having the compiler flags modified to allow for deprecated syscalls.
After this change, all versions of Darwin 16+ should correctly apply the
cxx flags. This is still a somewhat temporary fix because the real
issue (replacing the deprecated calls) has not been addressed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep cmake-list-darwin-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 51d26776c2c53bc8cb27fe0f3a1d4235f80cd10d
Author: cramja <ma...@gmail.com>
Date: 2017-02-07T17:28:39Z
Adds regex to specify 16.+ versions of Darwin
Before this change, only one recent version of Darwin was correcly
having the compiler flags modified to allow for deprecated syscalls.
After this change, all versions of Darwin 16+ should correcly apply the
cxx flags. This is still a somewhat temporary fix because the real
issue (replacing the deprecated calls) has not been addressed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #183: Adds regex to specify 16.+ versions o...
Posted by cramja <gi...@git.apache.org>.
Github user cramja closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
@jianqiao can I get a +1 when travis comes back?
ps
This doesn't solve the TCMALLOC issue. I tried using dynamic->static libs, and building perftools standalone. It compiles fine if I do it outside of CMAKE... so therefore it seems to be an issue with `ExternalProject`.
Did TCMALLOC ever work with Mac? Maybe this has to do with the 3rd party change, or not, I don't remember.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Thanks @cramja !! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
I sometimes encountered `tcmalloc` build issues on Mac, but it worked for a while before the third party changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
BTW this is so we can build on Mac. @pateljm
I'm still finding that I must specify `cmake -DUSE_TCMALLOC=FALSE ..`. Then it builds successfully on Mac.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
So far it is only the problem for Mac, so I disabled `tcmalloc` by `-DUSE_TCMALLOC=0` in `cmake` configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
What was your solution to tc malloc issue on mac, just ignore it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by cramja <gi...@git.apache.org>.
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Merged, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #183: Adds regex to specify 16.+ versions of Darwi...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/183
Next time, before merging, sync again your local branch with the master, and this PR will automatically merged, instead of manually closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---