You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/23 08:05:06 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue #16302: [OpenForce 2022] Remove useless`worker-id` props for sharding key generator

RaigorJiang opened a new issue #16302:
URL: https://github.com/apache/shardingsphere/issues/16302


   Hi community,
   
   This issue is for [OpenForce 2022](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
   
   ### Background
   Previously, we needed to specify the `worker-id` when creating a `snowflake` key generator object.
   But now that `worker-id` has been changed to a process-level configuration, there is no need to specify this parameter for each key generator.
   
   ### Aim
   Remove useless `worker-id` props as in #15608.
   
   for example:
   - in `ShowShardingTableRulesUsedAlgorithmQueryResultSetTest.java`
   ```java
   private ShardingSphereAlgorithmConfiguration createKeyGeneratorConfiguration() {
           Properties props = new Properties();
           props.put("worker-id", "123");
           return new ShardingSphereAlgorithmConfiguration("SNOWFLAKE", props);
       }
   ```
   
   change it to 
   ```java
   private ShardingSphereAlgorithmConfiguration createKeyGeneratorConfiguration() {
           return new ShardingSphereAlgorithmConfiguration("SNOWFLAKE", new Properties());
       }
   ```
   
   You can find similar code in:
   - `ShardingKeyGeneratorsQueryResultSetTest.java`
   - `UnusedShardingKeyGeneratorsQueryResultSetTest.java`
   also please change them.
   
   
   ### Basic Qualifications
   
   - Java
   - Maven


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] abhijeetjejurkar commented on issue #16302: [OpenForce 2022] Remove useless `worker-id` props for sharding key generator

Posted by GitBox <gi...@apache.org>.
abhijeetjejurkar commented on issue #16302:
URL: https://github.com/apache/shardingsphere/issues/16302#issuecomment-1076106835


   hey, can I try this issue?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #16302: [OpenForce 2022] Remove useless `worker-id` props for sharding key generator

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #16302:
URL: https://github.com/apache/shardingsphere/issues/16302#issuecomment-1076112005


   Sure, I'll assign it to you @abhijeetjejurkar .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org