Re: [15/17] git commit: TS-2302: separate predefined formats from LogFormat

[James Peach <jp...@apache.org>]

On Oct 31, 2013, at 3:40 PM, Igor Galić <i....@brainsware.org> wrote:

> 
> 
> ----- Original Message -----
>> TS-2302: separate predefined formats from LogFormat
>> 
>> LogFormat now only knows about text and custom logs. LogConfig still
>> have some knowledge of custom formats, but it is largeley separated
>> and doesn't have a LogFormat dependency any more. Remove various
>> predefined log constants and apply addition const to pass format
>> strings around.
> 
> How will this help us convert the configuration to Lua asap?
> (also, purge XML configs..)

I dunno. I guess that reducing code coupling help this, but that's not an explicit goal of this change.

>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/b95d1e89
>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/b95d1e89
>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/b95d1e89
>> 
>> Branch: refs/heads/master
>> Commit: b95d1e89a83377f9a0e8b845e19e510153124deb
> [snip]
>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/b95d1e89/proxy/logging/LogConfig.h
>> ----------------------------------------------------------------------
>> diff --git a/proxy/logging/LogConfig.h b/proxy/logging/LogConfig.h
>> index 2dc5bc6..00e5dd5 100644
>> --- a/proxy/logging/LogConfig.h
>> +++ b/proxy/logging/LogConfig.h
>> @@ -75,8 +75,8 @@ enum
>> extern RecRawStatBlock *log_rsb;
>> 
>> struct dirent;
> 
> This declaration is really odd here.

Yup.

J

Re: [15/17] git commit: TS-2302: separate predefined formats from LogFormat

[Igor Galić <i....@brainsware.org>]

> >> ----------------------------------------------------------------------
> >> diff --git a/proxy/logging/LogConfig.h b/proxy/logging/LogConfig.h
> >> index 2dc5bc6..00e5dd5 100644
> >> --- a/proxy/logging/LogConfig.h
> >> +++ b/proxy/logging/LogConfig.h
> >> @@ -75,8 +75,8 @@ enum
> >> extern RecRawStatBlock *log_rsb;
> >> 
> >> struct dirent;
> > 
> > This declaration is really odd here.
> 
> Yup.

perhaps we should clean this up.
I reckon that in most *Config.(cc?|h) files we're duplicating
reading configuration files, so perhaps we can consolidate that.

> J

++ i
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE