You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Lars Heinemann (JIRA)" <ji...@apache.org> on 2012/06/13 13:15:42 UTC

[jira] [Created] (CXF-4375) Archetypes are broken

Lars Heinemann created CXF-4375:
-----------------------------------

             Summary: Archetypes are broken
                 Key: CXF-4375
                 URL: https://issues.apache.org/jira/browse/CXF-4375
             Project: CXF
          Issue Type: Bug
    Affects Versions: 2.6.1
            Reporter: Lars Heinemann


The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 

{noformat}
## this is a sample comment line
{noformat}

which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann updated CXF-4375:
--------------------------------

    Affects Version/s: 2.7.0
    
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CXF-4375) Archetypes are broken

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Glen Mazza reassigned CXF-4375:
-------------------------------

    Assignee: Glen Mazza
    
> Archetypes are broken
> ---------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 
> {noformat}
> ## this is a sample comment line
> {noformat}
> which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Archetypes are broken

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294491#comment-13294491 ] 

Glen Mazza commented on CXF-4375:
---------------------------------

Hi, I need more information as I can't find the problem you're referring to (I'm doing a grep on the pom.xml's and it's returning nothing):

gmazza@gmazza-work:~/.../CXF-TRNK/maven-plugins/archetypes$ grep -r "sample comment" . --include "*.xml"

returns nothing; I switch "sample comment" to "name" and get tons of results.

Here's the 2.6.x branch:
http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/maven-plugins/archetypes/

Could you please point me to a pom.xml file that has "## this is a sample comment line" *and* a pom.xml file that uses $version instead of ${version}?

Thanks!
                
> Archetypes are broken
> ---------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 
> {noformat}
> ## this is a sample comment line
> {noformat}
> which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann updated CXF-4375:
--------------------------------

    Attachment: archetype.patch

Attached patch for trunk but should be fixed on 2.5 and 2.6 if possible as well.
                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294558#comment-13294558 ] 

Lars Heinemann edited comment on CXF-4375 at 6/13/12 6:16 PM:
--------------------------------------------------------------

Hi Glen,

the ## lines do mostly contain license stuff. I only wrote "this is a sample comment line" as symbol here.
Currently trying to fix that issue so I can deliver a patch to you. 

I am currently trying to create a patch for that. Will attach it here when finished.

                
      was (Author: lhein):
    Hi Glen,

the ## lines do mostly contain license stuff. I only wrote "this is a sample comment line" as symbol here.
Currently trying to fix that issue so I can deliver a patch to you. The comments are easily removed but the other
issue with the property placeholders is more complicated as you use resource filtering for having always the current
cxf release version in one dependency (${project.version}).
If you for example try to generate a module out of one of the two archetypes from the shell specifying the artifactId, groupId and version
of the new module then you will recognize that those values don't get included in the generated pom. It will still say $artifactId etc.
You also can't correct the notation to ${artifactId} for example as it will otherwise replace those in the archetype resources pom and so you 
have again the wrong data in the pom.

I am currently trying to create a patch for that. Will attach it here when finished.

                  
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294634#comment-13294634 ] 

Daniel Kulp commented on CXF-4375:
----------------------------------


Lars,

I'm failing to reproduce this issue.   If I run:
{code}
mvn archetype:generate
{code}

(maven 3.0.4) 

Filter to cxf-jaxws-javafirst.

Select version 2.6.1

Set groupId to "com.dkulp", artifactId to cxf-test, version to 1.0-SNAPSHOT, and defaults for rest, it generates a proper project with usable pom.xml, web.xml, and beans.xml.

I'm against your patch as that would result in the apache header being written out into the resulting beans.xml and web.xml, which would be wrong.   

Can I get COMPLETE steps to reproduce the issue?





                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Archetypes are broken

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294567#comment-13294567 ] 

Glen Mazza commented on CXF-4375:
---------------------------------

Cool, patches most welcome.  :)
                
> Archetypes are broken
> ---------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 
> {noformat}
> ## this is a sample comment line
> {noformat}
> which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294657#comment-13294657 ] 

Lars Heinemann commented on CXF-4375:
-------------------------------------

Hi Daniel,

mvn archetype:create seems to work fine. Though those files are not valid xml files and in my environment using m2e they make problems.
So my proposal is to fully remove the license text (we also did that in ServiceMix archetypes). It makes really no sense to have those 
license texts if they are not wanted in the created files and if they invalidate the xml.

What do you think?

                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294602#comment-13294602 ] 

Lars Heinemann commented on CXF-4375:
-------------------------------------

Hi Glen,

I figured out that one of the issues is not a problem on CXF side but on ours. But still the invalid XML files should be fixed.
Apologize for the confusion. :)
                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294633#comment-13294633 ] 

Glen Mazza commented on CXF-4375:
---------------------------------

Thanks, I'll check it next.
                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Archetypes are broken

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294558#comment-13294558 ] 

Lars Heinemann commented on CXF-4375:
-------------------------------------

Hi Glen,

the ## lines do mostly contain license stuff. I only wrote "this is a sample comment line" as symbol here.
Currently trying to fix that issue so I can deliver a patch to you. The comments are easily removed but the other
issue with the property placeholders is more complicated as you use resource filtering for having always the current
cxf release version in one dependency (${project.version}).
If you for example try to generate a module out of one of the two archetypes from the shell specifying the artifactId, groupId and version
of the new module then you will recognize that those values don't get included in the generated pom. It will still say $artifactId etc.
You also can't correct the notation to ${artifactId} for example as it will otherwise replace those in the archetype resources pom and so you 
have again the wrong data in the pom.

I am currently trying to create a patch for that. Will attach it here when finished.

                
> Archetypes are broken
> ---------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 
> {noformat}
> ## this is a sample comment line
> {noformat}
> which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294663#comment-13294663 ] 

Daniel Kulp commented on CXF-4375:
----------------------------------


Actually, I just tried with m2e in my eclipse install and it also worked fine there.  beans.xml and web.xml come out completely fine and usable without any license header or anything.

Thus, I really need instructions on how to reproduce this.

                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294662#comment-13294662 ] 

Daniel Kulp commented on CXF-4375:
----------------------------------


So this is a bug in m2e only?   Is a bug logged with them?   

Per Apache policy, any files that have creative content SHOULD have that license header.  Thus, it would really be against Apache policy to remove them.  
                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann updated CXF-4375:
--------------------------------

          Description: 
The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 

{noformat}
## <some license text>
{noformat}

which are not surrounded by a xml comment tag.


  was:
The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 

{noformat}
## this is a sample comment line
{noformat}

which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )



    Affects Version/s: 2.5.4
              Summary: Invalid XML files in the archetype cxf-jaxws-javafirst  (was: Archetypes are broken)
    
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CXF-4375) Invalid XML files in the archetype cxf-jaxws-javafirst

Posted by "Lars Heinemann (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Heinemann closed CXF-4375.
-------------------------------

    Resolution: Not A Problem

Found a suitable way to work around those invalid header comments. No need to fix that in cxf code any longer.
                
> Invalid XML files in the archetype cxf-jaxws-javafirst
> ------------------------------------------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.5.4, 2.6.1, 2.7.0
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>         Attachments: archetype.patch
>
>
> The archetype for cxf-jaxws-javafirst contain invalid xml files as they contain comment lines like 
> {noformat}
> ## <some license text>
> {noformat}
> which are not surrounded by a xml comment tag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4375) Archetypes are broken

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294496#comment-13294496 ] 

Glen Mazza commented on CXF-4375:
---------------------------------

On second thought, you may be referring *not* to the archetype source code itself but the code it generates.  To help me replicate, what are the steps you're following (command-line archetype generation or with m2eclipse?) And what's your Maven (and if you have it) maven-archetype version?  Thanks!
                
> Archetypes are broken
> ---------------------
>
>                 Key: CXF-4375
>                 URL: https://issues.apache.org/jira/browse/CXF-4375
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>            Reporter: Lars Heinemann
>            Assignee: Glen Mazza
>              Labels: archetype, cxf
>
> The archetypes for cxf-jaxrs-service and cxf-jaxws-javafirst are broken. Some of the contained xml files (not only the pom.xml) are invalid as they contain comment lines like 
> {noformat}
> ## this is a sample comment line
> {noformat}
> which are not surrounded by a xml comment tag and also the notation of property placeholders in the pom files are sometimes written in a wrong way. ( for example: $version instead of ${version} )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira