You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/02/19 12:53:45 UTC
[GitHub] [incubator-linkis] iture123 opened a new pull request #1536: Dev 1.3.0
iture123 opened a new pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536
### What is the purpose of the change
add new git Actions,that will check whether there are new third-party jar
### Brief change log
add new shell file regenerate_konwn_dependencies_txt.sh,run the shell to regenerate known-dependencies.txt
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] iture123 commented on a change in pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
iture123 commented on a change in pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#discussion_r810633616
##########
File path: .github/workflows/check_third_dependencies.yml
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: License check
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout source
+ uses: actions/checkout@v2
+ - name: Set up JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'adopt'
+ - name: mvn -N install
+ run:
+ mvn -N install
+ - name: mvn install
Review comment:
It is necessary ,pom.xml also introduce linkis related jar,which can only install from local when run 'dependency:copy-dependencies'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#issuecomment-1046019901
Is it reasonable to put it into the existing `License check `Action process?
I think it's ok to create a new action separately, but you need to rename the Acton name(eg:Third-party jar check) to distinguish it from the existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#issuecomment-1046021961
Every time we need to enter the detailed action process page to see the specific exception information, is there a easy way to display some failure information of the action on this page? Can something like git robot be used, of course this is another feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#issuecomment-1047402289
```
xml-apis-1.3.04.jar is not in file known-dependencies.txt!
Error: Process completed with exit code 1.
```
xml-apis-1.3.04.jar is missed in known-dependencies.txt!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a change in pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
casionone commented on a change in pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#discussion_r810491786
##########
File path: .github/workflows/check_third_dependencies.yml
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: License check
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout source
+ uses: actions/checkout@v2
+ - name: Set up JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'adopt'
+ - name: mvn -N install
+ run:
+ mvn -N install
+ - name: mvn install
Review comment:
`mvn install` is unnecessary.
Check does not depend on `mvn install`, I think it can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a change in pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
casionone commented on a change in pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#discussion_r810492019
##########
File path: .github/workflows/check_third_dependencies.yml
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: License check
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout source
+ uses: actions/checkout@v2
+ - name: Set up JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'adopt'
+ - name: mvn -N install
+ run:
+ mvn -N install
+ - name: mvn install
+ run:
+ mvn install
+ - name: mvn dependency:copy-dependencies
+ run:
+ mvn dependency:copy-dependencies -DincludeScope=runtime -DoutputDirectory=${{ github.workspace }}/current_dependencies
+ - name: generate current_dependencies.txt
+ run: |
+ ls ${{ github.workspace }}/current_dependencies |egrep -v "^linkis" |sort > ~/current_dependencies.txt
+ cat ~/current_dependencies.txt
+ - name: check third dependencies
+ run: |
+ sort ${{ github.workspace }}/tool/dependencies/known-dependencies.txt > ~/known-dependencies.txt
Review comment:
It is best to add some comments to explain the meaning of some command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] iture123 commented on pull request #1536: [fix #1395] add new git Actions to auto check for changes to third-party jar dependencies
Posted by GitBox <gi...@apache.org>.
iture123 commented on pull request #1536:
URL: https://github.com/apache/incubator-linkis/pull/1536#issuecomment-1046253021
>
I think it's better use new git Actions to check third-party dependencies,and I had renamed the Acton name.
> Is it reasonable to put it into the existing `License check `Action process? I think it's ok to create a new action separately, but you need to rename the Acton name(eg:Third-party jar check) to distinguish it from the existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org