You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/02/23 11:11:45 UTC

[GitHub] [hadoop] iwasakims commented on a change in pull request #2716: HADOOP-17538. Add kms-default.xml and httpfs-default.xml to site index.

iwasakims commented on a change in pull request #2716:
URL: https://github.com/apache/hadoop/pull/2716#discussion_r580950214



##########
File path: hadoop-project/src/site/site.xml
##########
@@ -216,6 +216,8 @@
       <item name="hdfs-rbf-default.xml" href="hadoop-project-dist/hadoop-hdfs-rbf/hdfs-rbf-default.xml"/>
       <item name="mapred-default.xml" href="hadoop-mapreduce-client/hadoop-mapreduce-client-core/mapred-default.xml"/>
       <item name="yarn-default.xml" href="hadoop-yarn/hadoop-yarn-common/yarn-default.xml"/>
+      <item name="kms-default.xml" href="hadoop-kms/kms-default.html"/>
+      <item name="httpfs-default.xml" href="hadoop-hdfs-httpfs/httpfs-default.html"/>

Review comment:
       > since some are going through hadoop-project-dist/
   
   @ayushtkn The placement of docs seems to be decided based on parent pom of the projects. hadoop-common and some hadoop-hdfs projects uses hadoop-project-dist as its parents.
   https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-common-project/hadoop-common/pom.xml#L20-L25
   
   The parent of hadoop-kms and hadoop-hdfs-httpfs and many other projects is hadoop-project.
   https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-common-project/hadoop-kms/pom.xml#L22-L27
   https://github.com/apache/hadoop/blob/rel/release-3.2.2/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L22-L27
   
   You can see the distribution by following cmdline on top of source tree.
   ```
   $ find . -name pom.xml | xargs grep -A5 '<parent>'  | less
   ```
   
   This inconsistency might come from historical reason and could be addressed in follow-up JIRAs.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org