You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/04/13 09:06:30 UTC

Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.


Diffs
-----

  src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
  src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
  src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
  src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
  src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
  src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
  src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
  src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
  src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
  src/tests/zookeeper_tests.cpp 29d68fee67342cdb274fadd529dc239afb014b93 

Diff: https://reviews.apache.org/r/10442/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/#review19240
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 15, 2013, 10:56 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10442/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
>   src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
>   src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
>   src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
>   src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
>   src/tests/monitor_tests.cpp ce9c1241a988b70ad57d7ca6785c45048002db77 
>   src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
>   src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
>   src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
>   src/tests/zookeeper_tests.cpp 37e1b77a9c728034936eddd451c75a46605885db 
> 
> Diff: https://reviews.apache.org/r/10442/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/
-----------------------------------------------------------

(Updated April 15, 2013, 10:56 p.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.


Diffs (updated)
-----

  src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
  src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
  src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
  src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
  src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
  src/tests/monitor_tests.cpp ce9c1241a988b70ad57d7ca6785c45048002db77 
  src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
  src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
  src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
  src/tests/zookeeper_tests.cpp 37e1b77a9c728034936eddd451c75a46605885db 

Diff: https://reviews.apache.org/r/10442/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/#review19141
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 13, 2013, 7:06 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10442/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 7:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
> 
> 
> Description
> -------
> 
> Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
>   src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
>   src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
>   src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
>   src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
>   src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
>   src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
>   src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
>   src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
>   src/tests/zookeeper_tests.cpp 29d68fee67342cdb274fadd529dc239afb014b93 
> 
> Diff: https://reviews.apache.org/r/10442/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/
-----------------------------------------------------------

(Updated April 13, 2013, 7:06 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.


Diffs
-----

  src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
  src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
  src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
  src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
  src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
  src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
  src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
  src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
  src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
  src/tests/zookeeper_tests.cpp 29d68fee67342cdb274fadd529dc239afb014b93 

Diff: https://reviews.apache.org/r/10442/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Fixed Mesos tests to use new Clock::advance() and Clock::update() methods with Duration.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10442/
-----------------------------------------------------------

(Updated April 13, 2013, 7:06 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

Separated out Mesos specific changes (from libprocess ones) in the last commit. Rebased off trunk.


Diffs
-----

  src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f 
  src/tests/fault_tolerance_tests.cpp bfb30344ca02cd42c442a373d44d6a3fa287c1e3 
  src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d 
  src/tests/log_tests.cpp 8bb429ab35055077ea1e136f2f02a0855c6a8ea4 
  src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e 
  src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe 
  src/tests/reaper_tests.cpp f05f98956caaebaad6b115fdb9bf62d3232f7b1b 
  src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e 
  src/tests/status_update_manager_tests.cpp 23ba5a10200f6c9ff677bdaa760c764581c3c63b 
  src/tests/zookeeper_tests.cpp 29d68fee67342cdb274fadd529dc239afb014b93 

Diff: https://reviews.apache.org/r/10442/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu