[GitHub] [nifi] patricker commented on a change in pull request #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue

[GitBox <gi...@apache.org>]

patricker commented on a change in pull request #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue
URL: https://github.com/apache/nifi/pull/3440#discussion_r276807925
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-queue-listing.js
 ##########
 @@ -675,6 +692,15 @@
                         nfShell.showPage('provenance?' + $.param({
                                 flowFileUuid: item.uuid
                             }));
+                    } else if (target.hasClass('disabled')) {
+                        nfDialog.showOkDialog({
+                            headerText: 'Empty FlowFile',
+                            dialogContent: 'This FlowFile contains no content to complete this action.'
 
 Review comment:
   Since you are applying the disabled class to this button in this scenario already, what is the motivation of having the popup when the user clicks it? To me this feels unintuitive, I don't think most users would try to click a disabled button, especially when they can see other ones that aren't disabled.
   
   My personal preference would be to either just have nothing, keep button disabled and show no dialog on click, or add a mouse hover bubble saying the same message you have in the popup.  What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services