You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 09:10:03 UTC

[GitHub] [airflow] Goodkat edited a comment on issue #15016: OdbcHook string values in connect_kwargs dict converts to None

Goodkat edited a comment on issue #15016:
URL: https://github.com/apache/airflow/issues/15016#issuecomment-826650629


   @marcosmarxm I have removed `clean_bool ` on my local copy and can confirm that it returns the **schema_name** instead of `None` now. 
   I used the folowing UI extras for my tests and it works for unquoted boolean values as well:
   ```json
   {
     "connect_kwargs": {
       "CurrentSchema": "SCHEMA",
       "Blah": true,
       "Blah2": false
     }
   }
   ```
   ```python
   >>> from airflow.providers.odbc.hooks.odbc import OdbcHook                                         
   >>> OdbcHook('myconn').connect_kwargs
   {'CurrentSchema': 'SCHEMA', 'Blah': True, 'Blah2': False}
   ```
   
   As the next step, I will make and commit the changes within the PR #15510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org