You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/04/18 21:54:59 UTC

[GitHub] [arrow] kevingurney opened a new issue, #35221: [MATLAB] Consider lowering the minimum CMake version requirement for building the MATLAB interface

kevingurney opened a new issue, #35221:
URL: https://github.com/apache/arrow/issues/35221

   ### Describe the enhancement requested
   
   As discussed in this [comment thread](https://github.com/apache/arrow/pull/34563#discussion_r1137882276), the MATLAB interface currently defines a relatively high minimum CMake version (i.e. [`cmake_minimum_required`](https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html)) of `3.20`. For comparison, [the C++ libraries define a minimum required CMake version of `3.5`](https://github.com/apache/arrow/blob/72d57ac4ccc1c80003481d04ad23159c5ed2c2f1/cpp/CMakeLists.txt#L18).
   
   The minimum CMake version for the MATLAB interface was originally [increased from `3.2` to `3.20` to work around some bugs in `FindMatlab` that were making development more challenging](https://github.com/apache/arrow/pull/10305#discussion_r657176867).
   
   It may be worth revisiting this decision and doing a thorough investigation into whether there are any opportunities to lower the minimum required CMake version to ensure broader compatibility with older CMake versions.
   
   This would be a good first issue for any community members who are interested in contributing to the MATLAB interface and would like to get some experience using CMake. This would involve building the interface against versions of CMake prior to `3.20` on Windows, macOS, and Linux, and seeing whether there are any issues that come up.
   
   ### Component(s)
   
   MATLAB


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on issue #35221: [MATLAB] Consider lowering the minimum CMake version requirement for building the MATLAB interface

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35221:
URL: https://github.com/apache/arrow/issues/35221#issuecomment-1513911275

   I've added them.
   
   FYI: The C++ implementation requires CMake 3.16 or later soon: #34921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kevingurney commented on issue #35221: [MATLAB] Consider lowering the minimum CMake version requirement for building the MATLAB interface

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on issue #35221:
URL: https://github.com/apache/arrow/issues/35221#issuecomment-1513841111

   I don't believe I have the permissions to add additional labels to this issue. However, I think it would make sense to add the [`good-first-issue`](https://github.com/apache/arrow/labels/good-first-issue) and/or [`good-second-issue`](https://github.com/apache/arrow/labels/good-second-issue) labels to this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kevingurney commented on issue #35221: [MATLAB] Consider lowering the minimum CMake version requirement for building the MATLAB interface

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on issue #35221:
URL: https://github.com/apache/arrow/issues/35221#issuecomment-1514894221

   Thanks for adding the labels and for pointing this out @kou!
   
   Given this information, it probably wouldn't make sense to go any lower than `3.16` for the minimum required CMake version for the MATLAB interface since it depends on the `CMakeLists.txt` for the the C++ libraries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org