You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/02/08 22:38:28 UTC

[kudu-CR] [tools] Add tool to list data dirs for a tablet 

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12417


Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................

[tools] Add tool to list data dirs for a tablet

It's hard to find out what the data dirs are for a tablet, given its
tablet id, but it might be useful to do so. For example, if a user is
trying to correlate disk utilization to busy tablets, it's useful to
know which tablets will cause disk activity on which devices.

Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 67 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/12417/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12417

to look at the new patch set (#2).

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................

[tools] Add tool to list data dirs for a tablet

It's hard to find out what the data dirs are for a tablet, given its
tablet id, but it might be useful to do so. For example, if a user is
trying to correlate disk utilization to busy tablets, it's useful to
know which tablets will cause disk activity on which devices.

Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
2 files changed, 69 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/12417/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12417

to look at the new patch set (#4).

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................

[tools] Add tool to list data dirs for a tablet

It's hard to find out what the data dirs are for a tablet, given its
tablet id, but it might be useful to do so. For example, if a user is
trying to correlate disk utilization to busy tablets, it's useful to
know which tablets will cause disk activity on which devices.

Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
4 files changed, 100 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/12417/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692
PS3, Line 692:   // Load the tablet meta to make sure the tablet's data directories are loaded
             :   // into the manager.
> Ah, so we would get that dir printed in the error message, and everyone can
Agh sorry, it would successfully call Load(), but it wouldn't register a group because some of the UUIDs are missing. So the error I think would come from FindDataDirsByTabletId(), saying there is no data dir group for the tablet. IIRC there will be a warning logged about why this is the case, so I think this is fine.



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:56:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12417/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12417/1//COMMIT_MSG@12
PS1, Line 12: know which tablets will cause disk activity on which devices.
if this is about runtime understanding of device activity, wouldn't this make more sense to be remotely accessible? ie part of kudu remote_tablet or kudu tserver list_tablets or somesuch?



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 08 Feb 2019 22:55:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:15:54 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................

[tools] Add tool to list data dirs for a tablet

It's hard to find out what the data dirs are for a tablet, given its
tablet id, but it might be useful to do so. For example, if a user is
trying to correlate disk utilization to busy tablets, it's useful to
know which tablets will cause disk activity on which devices.

Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Reviewed-on: http://gerrit.cloudera.org:8080/12417
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
4 files changed, 100 insertions(+), 1 deletion(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Adar Dembo: Looks good to me, approved
  Will Berkeley: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1193
PS3, Line 1193:   TabletMetadata::CreateNew(&fs, kTestTablet, kTestTableName, kTestTableId,
Should ASSERT_OK on this.


http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1204
PS3, Line 1204:   const auto data_roots = fs.GetDataRootDirs();
              :   ASSERT_EQ(1, data_roots.size());
              :   ASSERT_EQ(data_roots[0], stdout);
Could you test on multiple data directories?


http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692
PS3, Line 692:   // Load the tablet meta to make sure the tablet's data directories are loaded
             :   // into the manager.
Will it fail if a data dir is missing? Is that even desirable in this case? Seems like it'd be useful to print data dirs that are missing (if we can).



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 19:22:12 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1193
PS3, Line 1193:   TabletMetadata::CreateNew(&fs, kTestTablet, kTestTableName, kTestTableId,
> Should ASSERT_OK on this.
Done


http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1199
PS3, Line 1199:   NO_FATALS(RunActionStdoutString(Substitute("local_replica dump data_dirs $0 "
              :                                              "--fs_wal_dir=$1 "
              :                                              "--fs_data_dirs=$2",
              :                                              kTestTablet, kTestDir,
              :                                              kTestDir), &stdout));
> Might be nice to run this on a tablet that doesn't exist if you haven't alr
There's an error about missing tablet metadata in that case.


http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1204
PS3, Line 1204:   const auto data_roots = fs.GetDataRootDirs();
              :   ASSERT_EQ(1, data_roots.size());
              :   ASSERT_EQ(data_roots[0], stdout);
> Could you test on multiple data directories?
Done


http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692
PS3, Line 692:   // Load the tablet meta to make sure the tablet's data directories are loaded
             :   // into the manager.
> Will it fail if a data dir is missing? Is that even desirable in this case?
The purpose of the tool is to figure out which data dirs hold data for the tablet, so activity on data dirs can be correlated with activity on the tablet. It's not a diagnostic tool to tell what's missing and why. I think the tool would fail because it wouldn't be able to open the FsManager in that case?



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 20:34:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 3:

(1 comment)

Alexey says the IWYU thing is fixed once I rebase.

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692
PS3, Line 692:   // Load the tablet meta to make sure the tablet's data directories are loaded
             :   // into the manager.
> Missing data dirs, like failed dirs, won't break the FsManager. Rather, the
Ah, so we would get that dir printed in the error message, and everyone can be happy?



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 22:14:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/tool_action_local_replica.cc@692
PS3, Line 692:   // Load the tablet meta to make sure the tablet's data directories are loaded
             :   // into the manager.
> The purpose of the tool is to figure out which data dirs hold data for the 
Missing data dirs, like failed dirs, won't break the FsManager. Rather, the TabletMetadata would fail to Load upon realizing that one of the data dir UUIDs it expected is missing.



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Feb 2019 21:51:41 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/12417/3/src/kudu/tools/kudu-tool-test.cc@1199
PS3, Line 1199:   NO_FATALS(RunActionStdoutString(Substitute("local_replica dump data_dirs $0 "
              :                                              "--fs_wal_dir=$1 "
              :                                              "--fs_data_dirs=$2",
              :                                              kTestTablet, kTestDir,
              :                                              kTestDir), &stdout));
Might be nice to run this on a tablet that doesn't exist if you haven't already, just to make sure the output is sensible (appropriate error message).



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 18:41:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12417

to look at the new patch set (#3).

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................

[tools] Add tool to list data dirs for a tablet

It's hard to find out what the data dirs are for a tablet, given its
tablet id, but it might be useful to do so. For example, if a user is
trying to correlate disk utilization to busy tablets, it's useful to
know which tablets will cause disk activity on which devices.

Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
4 files changed, 90 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/12417/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12417/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12417/1//COMMIT_MSG@12
PS1, Line 12: know which tablets will cause disk activity on which devices.
> if this is about runtime understanding of device activity, wouldn't this ma
I think it makes sense both ways- this way you can get the information when the server is offline, say if you want to know ahead of time what tablets would be affected. It will also work on older versions. I will do a follow-up to add the information to an RPC response so the data dir group will be retrievable from newer servers remotely.



-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 18:06:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Add tool to list data dirs for a tablet

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12417 )

Change subject: [tools] Add tool to list data dirs for a tablet
......................................................................


Patch Set 4: Verified+1

IWYU was broken for this patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/12417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6de565e4061eb8248b453d2230847e064040ff
Gerrit-Change-Number: 12417
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 18:10:14 +0000
Gerrit-HasComments: No