You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/04/01 00:57:37 UTC
[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115
Changes to stop using global object - remove all created contacts from the emulator
Issues Addressed:
1. Removing Global gContactObj
2. Clean up all the contacts created correctly
@omefire @riknoll @rakatyal @nikhilkh Can you please review and merge this PR?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-plugin-contacts flakytests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit e1922358a05bd37bd3b5a82aa0445e1c35503b4b
Author: Sarangan Rajamanickam <sa...@microsoft.com>
Date: 2016-03-31T22:31:15Z
Changes to stop using global object - remove all created contacts from the emulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#issuecomment-204604763
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#discussion_r58141525
--- Diff: tests/tests.js ---
@@ -51,14 +48,14 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 30000;
var HIGH_TIMEOUT = 120000;
- var removeContact = function(done) {
- if (!gContactObj) {
+ var removeContact = function(done, contactObj) {
+ if (!contactObj) {
done();
return;
}
- gContactObj.remove(function() {
- gContactObj = null;
+ contactObj.remove(function() {
+ contactObj = null;
--- End diff --
I don't think you need this reassignment anymore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Changes to stop using global...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/115#discussion_r58141872
--- Diff: tests/tests.js ---
@@ -51,14 +48,14 @@ exports.defineAutoTests = function() {
var MEDIUM_TIMEOUT = 30000;
var HIGH_TIMEOUT = 120000;
- var removeContact = function(done) {
- if (!gContactObj) {
+ var removeContact = function(done, contactObj) {
+ if (!contactObj) {
done();
return;
}
- gContactObj.remove(function() {
- gContactObj = null;
+ contactObj.remove(function() {
+ contactObj = null;
--- End diff --
True. Removed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org