You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/14 08:26:55 UTC
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6200: NIFI-10223 Created ListGoogleDrive processor.
turcsanyip commented on code in PR #6200:
URL: https://github.com/apache/nifi/pull/6200#discussion_r920881589
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java:
##########
@@ -105,17 +106,6 @@
.sensitive(true)
.build();
- /**
- * Links to the {@link GCPCredentialsService} which provides credentials for this particular processor.
- */
- public static final PropertyDescriptor GCP_CREDENTIALS_PROVIDER_SERVICE = new PropertyDescriptor.Builder()
- .name("gcp-credentials-provider-service")
- .name("GCP Credentials Provider Service")
- .description("The Controller Service used to obtain Google Cloud Platform credentials.")
- .required(true)
- .identifiesControllerService(GCPCredentialsService.class)
- .build();
-
Review Comment:
In order to keep backward compatibility, this `public` field should not be removed (3rd party custom processors may use it).
Workaround could be:
```
@Deprecated
public static final PropertyDescriptor GCP_CREDENTIALS_PROVIDER_SERVICE = GoogleUtils.GCP_CREDENTIALS_PROVIDER_SERVICE;
```
##########
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/pom.xml:
##########
@@ -114,6 +114,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>com.google.apis</groupId>
+ <artifactId>google-api-services-drive</artifactId>
+ <version>v3-rev20211107-1.32.1</version>
+ </dependency>
Review Comment:
Please check the implications of this new dependency in terms of licensing. I think it needs to be added in the NOTICE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org