[GitHub] [tinkerpop] kenhuuu commented on a diff in pull request #1986: TINKERPOP-2373 Bump to Groovy 4.0.9/GMavenPlus 2.1.0

["kenhuuu (via GitHub)" <gi...@apache.org>]

kenhuuu commented on code in PR #1986:
URL: https://github.com/apache/tinkerpop/pull/1986#discussion_r1137812418


##########
gremlin-console/src/main/static/NOTICE:
##########
@@ -18,15 +18,10 @@ Original source copyright:
 Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
 
 ------------------------------------------------------------------------
-Apache Groovy 2.5.15 (AL ASF)
+Apache Groovy 4.0.9 (AL ASF)
 ------------------------------------------------------------------------
-This product includes/uses ANTLR (http://www.antlr2.org/)
-developed by Terence Parr 1989-2006
-
-This product bundles icons from the famfamfam.com silk icons set
-http://www.famfamfam.com/lab/icons/silk/

Review Comment:
   > Was this piece intended to be removed? Are the icons no longer bundled?
   
   The NOTICE file doesn't exist anymore in the groovy-console 4.0.9 jar, however, it does exist in https://github.com/apache/groovy/blob/GROOVY_4_0_9/subprojects/groovy-console/NOTICE so maybe we should add it back? In any case, groovy-console is only included with gremlin-server and not gremlin-console.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org