[GitHub] [zookeeper] eolivelli commented on a change in pull request #1120: ZOOKEEPER-3579: Handle null default watcher gracefully

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1120: ZOOKEEPER-3579: Handle null default watcher gracefully
URL: https://github.com/apache/zookeeper/pull/1120#discussion_r406742609
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
 ##########
 @@ -3398,6 +3403,26 @@ private ClientCnxnSocket getClientCnxnSocket() throws IOException {
         }
     }
 
+    /**
+     * Return the default watcher of this instance if requested.
+     *
+     * @param requested if the default watcher requested
+     * @return the default watcher if request, otherwise {@code null}.
+     * @throws IllegalStateException if a null default watcher is requested
+     */
+    @Nullable
 
 Review comment:
   I am not sure about this.
   Are we using it in ZK?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services