[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1181: Refactor quota mgr

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #1181:
URL: https://github.com/apache/servicecomb-service-center/pull/1181#discussion_r772059047



##########
File path: server/plugin/quota/request.go
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package quota
+
+type ResourceType string
+
+type Request struct {
+	QuotaType     ResourceType
+	DomainProject string
+	ServiceID     string
+	QuotaSize     int64
+}
+
+func NewRequest(quotaType ResourceType, domainProject, serviceID string, quotaSize int64) *Request {

Review comment:
       以后不必写这种函数，这么多入参，不太好构建，如果不想用struct来构建，那就用builder模式




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org