You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by Apache Wiki <wi...@apache.org> on 2009/05/06 04:58:19 UTC

[Cassandra Wiki] Update of "HowToCommit" by EricEvans

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Cassandra Wiki" for change notification.

The following page has been changed by EricEvans:
http://wiki.apache.org/cassandra/HowToCommit

The comment on the change is:
imported from confluence wiki (with a couple of editorial changes for relevancy)

New page:
== New committers ==

New committers are encouraged to first read Apache's generic committer documentation:

 * [http://www.apache.org/dev/new-committers-guide.html Apache New Committer Guide]
 * [http://www.apache.org/dev/committers.html Apache Committer FAQ]

== Review ==
Committers should, as often as possible, attempt to review patches submitted by others. See the list of [https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310865&status=10002 available patches]. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews and believe it to be of sufficient quality and the unit tests pass, then they can commit the patch, otherwise the patch should be canceled with a clear explanation for why it was rejected. 

== Reject ==

Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

== Commit ==

When you commit a patch, please:
 1. Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you.  Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these).
 1. Resolve the issue as fixed, thanking the contributor. Always set the "Fix Version" at this point, but please only set a single fix version, the earliest release in which the change will appear.