You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/14 17:10:51 UTC
Review Request 26689: Create App,
step2. User can input negative value and proceed next
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26689/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: AMBARI-7775
https://issues.apache.org/jira/browse/AMBARI-7775
Repository: ambari
Description
-------
Create App, step2. User can input negative value and proceed next
Diffs
-----
contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 55f0451
contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step1.hbs f25bc04
contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step2.hbs bf18b16
contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 0aa3604
contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step2_controller_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26689/diff/
Testing
-------
98 assertions of 98 passed, 0 failed.
Thanks,
Oleg Nechiporenko
Re: Review Request 26689: Create App,
step2. User can input negative value and proceed next
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26689/#review56531
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 14, 2014, 3:10 після полудня, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26689/
> -----------------------------------------------------------
>
> (Updated Жов. 14, 2014, 3:10 після полудня)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7775
> https://issues.apache.org/jira/browse/AMBARI-7775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create App, step2. User can input negative value and proceed next
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 55f0451
> contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step1.hbs f25bc04
> contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step2.hbs bf18b16
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 0aa3604
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step2_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26689/diff/
>
>
> Testing
> -------
>
> 98 assertions of 98 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 26689: Create App,
step2. User can input negative value and proceed next
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26689/#review56530
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 14, 2014, 3:10 п.п., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26689/
> -----------------------------------------------------------
>
> (Updated Окт. 14, 2014, 3:10 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7775
> https://issues.apache.org/jira/browse/AMBARI-7775
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create App, step2. User can input negative value and proceed next
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 55f0451
> contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step1.hbs f25bc04
> contrib/views/slider/src/main/resources/ui/app/templates/createAppWizard/step2.hbs bf18b16
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 0aa3604
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step2_controller_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26689/diff/
>
>
> Testing
> -------
>
> 98 assertions of 98 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>