You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2024/01/10 01:12:24 UTC
[PR] GH-33464: [R] Troubles with using augmented columns [arrow]
thisisnic opened a new pull request, #39542:
URL: https://github.com/apache/arrow/pull/39542
### Rationale for this change
Fixes a bug whereby augmented columns couldn't be used in subsequent expressions
### What changes are included in this PR?
Includes the augmented column in the schema for the ScanNode
### Are these changes tested?
Yes
### Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-33464: [R] Troubles with using augmented columns [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #39542: GH-33464: [R] Troubles with using augmented columns
URL: https://github.com/apache/arrow/pull/39542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-33464: [R] Troubles with using augmented columns [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #39542:
URL: https://github.com/apache/arrow/pull/39542#issuecomment-1884079676
Closing this as the changes that need making appear to be at in libarrow not the R package C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-33464: [R] Troubles with using augmented columns [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #39542:
URL: https://github.com/apache/arrow/pull/39542#discussion_r1446781427
##########
r/src/compute-exec.cpp:
##########
@@ -302,6 +301,8 @@ std::shared_ptr<acero::ExecNode> ExecNode_Scan(
"make_struct", std::move(exprs),
compute::MakeStructOptions{cpp11::as_cpp<std::vector<std::string>>(field_names)});
+ options->dataset_schema = GetProjectedSchemaFromExpression(options->projection, dataset->schema());
Review Comment:
I don't think we can actually do this this way as this function is internal, but I think that we need to do something like what this does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-33464: [R] Troubles with using augmented columns [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39542:
URL: https://github.com/apache/arrow/pull/39542#issuecomment-1884037016
:warning: GitHub issue #33464 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org