You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by Indika Kumara <in...@gmail.com> on 2017/08/19 09:30:01 UTC

Regarding Regression Testing

I created test method like below, Is it OK?

//=================================================================================================
    //test 5261 bug fix
    public void testDerby5261(String[] pingCmd,String expectedMessage){
        assertExecJavaCmdAsExpected(new String[] {expectedMessage},
pingCmd, 1);
    }
//=================================================================================================

Re: Regarding Regression Testing

Posted by Kristian Waagan <kr...@apache.org>.

Hi Indika,

Great that you want to add a test for your fix 😊 A few questions from only
looking at the code you provided:

What do you want this test to test / ascertain?
How will the test method be invoked, more specifically, what will the
values of the arguments be?

Also, since Derby has two types of test frameworks (JUnit and a home-grown
one), for which framework is this test intended?

Best regards,
-- 
Kristian

On lør. 19. aug. 2017, 11:30 Indika Kumara <in...@gmail.com> wrote:

> I created test method like below, Is it OK?
>
>
> //=================================================================================================
>     //test 5261 bug fix
>     public void testDerby5261(String[] pingCmd,String expectedMessage){
>         assertExecJavaCmdAsExpected(new String[] {expectedMessage},
> pingCmd, 1);
>     }
>
> //=================================================================================================
>
>