You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <pl...@hi5.com> on 2008/02/29 08:33:13 UTC
Re: svn commit: r631989 -
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shind
ig/gadgets/http/GadgetRenderingServlet.java
On Thu, Feb 28, 2008 at 11:29:48PM -0800, Dan Peterson wrote:
> Is there some reason this doesn't also need the following?
>
> markup.append("</html>");
>
That's already in there..
arcwelder-2:hi5platform plindner$ grep /body
shindig/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
markup.append("</body></html>");
The begin tags got missed during the quirks/non-quirks patch.
> On Thu, Feb 28, 2008 at 7:08 AM, <li...@apache.org> wrote:
>
> > Author: lindner
> > Date: Thu Feb 28 07:07:49 2008
> > New Revision: 631989
> >
> > URL: http://svn.apache.org/viewvc?rev=631989&view=rev
> > Log:
> > Ensure we generate a proper html doc, by correctly sending head and body
> > tags
> >
> > Modified:
> >
> > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> >
> > Modified:
> > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > URL:
> > http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java?rev=631989&r1=631988&r2=631989&view=diff
> >
> > ==============================================================================
> > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > (original)
> > +++
> > incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > Thu Feb 28 07:07:49 2008
> > @@ -207,6 +207,7 @@
> > markup.append("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01//EN\"
> > \"http://www.w3.org/TR/html4/strict.dtd\<http://www.w3.org/TR/html4/strict.dtd%5C>
> > ">");
> > }
> >
> > + markup.append("<html><head>");
> > // TODO: This is so wrong.
> > markup.append("<style type=\"text/css\">")
> > .append("body,td,div,span,p{font-family:arial,sans-serif;}")
> > @@ -214,6 +215,7 @@
> > .append("a:active {color:#ff0000;}")
> > .append("body{margin: 0px;padding:
> > 0px;background-color:white;}")
> > .append("</style>");
> > + markup.append("</head><body>");
> > StringBuilder externJs = new StringBuilder();
> > StringBuilder inlineJs = new StringBuilder();
> > String externFmt = "<script src=\"%s\"></script>";
> >
> >
> >
--
Paul Lindner
hi5 Architect
plindner@hi5.com
Re: svn commit: r631989 - /incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shind ig/gadgets/http/GadgetRenderingServlet.java
Posted by Dan Peterson <dp...@google.com>.
Ah, my bad. Was focused on the diff for the latest rev.
-Dan
On Thu, Feb 28, 2008 at 11:33 PM, Paul Lindner <pl...@hi5.com> wrote:
> On Thu, Feb 28, 2008 at 11:29:48PM -0800, Dan Peterson wrote:
> > Is there some reason this doesn't also need the following?
> >
> > markup.append("</html>");
> >
>
> That's already in there..
>
> arcwelder-2:hi5platform plindner$ grep /body
>
> shindig/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> markup.append("</body></html>");
>
>
> The begin tags got missed during the quirks/non-quirks patch.
>
> > On Thu, Feb 28, 2008 at 7:08 AM, <li...@apache.org> wrote:
> >
> > > Author: lindner
> > > Date: Thu Feb 28 07:07:49 2008
> > > New Revision: 631989
> > >
> > > URL: http://svn.apache.org/viewvc?rev=631989&view=rev
> > > Log:
> > > Ensure we generate a proper html doc, by correctly sending head and
> body
> > > tags
> > >
> > > Modified:
> > >
> > >
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > >
> > > Modified:
> > >
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > > URL:
> > >
> http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java?rev=631989&r1=631988&r2=631989&view=diff
> > >
> > >
> ==============================================================================
> > >
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > > (original)
> > > +++
> > >
> incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
> > > Thu Feb 28 07:07:49 2008
> > > @@ -207,6 +207,7 @@
> > > markup.append("<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01
> //EN\"
> > > \"http://www.w3.org/TR/html4/strict.dtd\<http://www.w3.org/TR/html4/strict.dtd%5C>
> <http://www.w3.org/TR/html4/strict.dtd%5C>
> > > ">");
> > > }
> > >
> > > + markup.append("<html><head>");
> > > // TODO: This is so wrong.
> > > markup.append("<style type=\"text/css\">")
> > > .append("body,td,div,span,p{font-family:arial,sans-serif;}")
> > > @@ -214,6 +215,7 @@
> > > .append("a:active {color:#ff0000;}")
> > > .append("body{margin: 0px;padding:
> > > 0px;background-color:white;}")
> > > .append("</style>");
> > > + markup.append("</head><body>");
> > > StringBuilder externJs = new StringBuilder();
> > > StringBuilder inlineJs = new StringBuilder();
> > > String externFmt = "<script src=\"%s\"></script>";
> > >
> > >
> > >
>
> --
> Paul Lindner
> hi5 Architect
> plindner@hi5.com
>