You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/21 01:16:45 UTC

[GitHub] upgle opened a new pull request #3316: Add conditional statement to check metricsKamon flag.

upgle opened a new pull request #3316: Add conditional statement to check metricsKamon flag.
URL: https://github.com/apache/incubator-openwhisk/pull/3316
 
 
   
   Recently added all MetricEmitter logic does not check metricsKamon config is enabled.
   
   
   ```scala
   if (TransactionId.metricsKamon) {
           MetricEmitter.emitHistogramMetric(token, tid.deltaToStart)
           MetricEmitter.emitCounterMetric(token)
   }
   ```
   https://github.com/apache/incubator-openwhisk/blob/925500cf8d34bb75bebd077ea057af236eba0b01/common/scala/src/main/scala/whisk/http/BasicHttpService.scala#L127

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services