You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rafafrdz (via GitHub)" <gi...@apache.org> on 2026/03/29 09:03:02 UTC
[PR] [SPARK-52428] Add comprehensive CI workflow with unit and integration tests [spark-connect-rust]
rafafrdz opened a new pull request, #40:
URL: https://github.com/apache/spark-connect-rust/pull/40
## Summary
Add a new `ci.yml` workflow that improves on the existing `build.yml` with:
### Jobs
| Job | What it does | Needs Spark? |
|-----|-------------|--------------|
| **lint** | `cargo fmt --check` + `cargo clippy -D warnings` (default + all features) | No |
| **unit-tests** | Build + test across feature matrix (4 combinations) | No |
| **docs** | `cargo doc` with `-D warnings` | No |
| **integration-tests** | Full test suite against Docker Spark Connect server | Yes |
### Improvements over existing `build.yml`
- **Feature matrix testing** — tests default, `polars`, `datafusion`, and combined features separately
- **Smart unit test detection** — distinguishes transport errors (expected without Spark) from real failures
- **Server readiness check** — waits up to 60s for Spark Connect with `nc` probe before running integration tests
- **Failure diagnostics** — dumps `docker compose logs` on integration test failure
- **Updated actions** — uses `arduino/setup-protoc@v3` (not v2), `dtolnay/rust-toolchain@stable`
- **Triggers on `dev` branch** — supports the fork's integration branch
## Test plan
- [x] Workflow YAML is valid
- [x] Covers all feature combinations
- [x] Integration tests wait for server readiness
- [x] Failure diagnostics included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52428] Add comprehensive CI workflow with unit and integration tests [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40:
URL: https://github.com/apache/spark-connect-rust/pull/40#issuecomment-5403898866
Superseded by #50, which delivers the consolidated Rust core Spark Connect client (now merged to `master`) and incorporates this work. Closing to keep the queue focused on the drop-in Python wrapper (#51). Thanks for the contribution — please reopen if anything here isn't covered by #50.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52428] Add comprehensive CI workflow with unit and integration tests [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40: [SPARK-52428] Add comprehensive CI workflow with unit and integration tests
URL: https://github.com/apache/spark-connect-rust/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org