You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "paulkagiri (via GitHub)" <gi...@apache.org> on 2026/05/08 14:32:44 UTC
[PR] Fix Kubernetes worker service account values [airflow]
paulkagiri opened a new pull request, #66598:
URL: https://github.com/apache/airflow/pull/66598
Fixes #66579.
When `workers.kubernetes.serviceAccount.create` is explicitly set to `false`, the pod template should still use the Kubernetes worker service account name from `workers.kubernetes.serviceAccount.name` instead of falling back to the deprecated `workers.serviceAccount` values. For a pure `KubernetesExecutor` deployment, the legacy worker ServiceAccount should also not be rendered in that explicit Kubernetes service account path.
This keeps the existing default fallback when the Kubernetes worker service account section is not explicitly configured.
Tests:
- `PYTHONPATH=chart/tests python -m pytest chart/tests/helm_tests/airflow_aux/test_pod_template_file.py::TestPodTemplateFile::test_dedicated_service_account_name_when_creation_disabled chart/tests/helm_tests/airflow_core/test_worker.py::TestWorkerKubernetesServiceAccount::test_should_not_create_legacy_service_account_when_k8s_service_account_disabled -q`
- `PYTHONPATH=chart/tests python -m pytest chart/tests/helm_tests/airflow_aux/test_pod_template_file.py::TestPodTemplateFile::test_service_account_name_default chart/tests/helm_tests/airflow_aux/test_pod_template_file.py::TestPodTemplateFile::test_dedicated_service_account_name_default chart/tests/helm_tests/airflow_core/test_worker.py::TestWorkerKubernetesServiceAccount::test_should_create_service_account_when_enabled -q`
- `python -m black --check --target-version py312 chart/tests/helm_tests/airflow_aux/test_pod_template_file.py chart/tests/helm_tests/airflow_core/test_worker.py`
- `python -m ruff check chart/tests/helm_tests/airflow_aux/test_pod_template_file.py chart/tests/helm_tests/airflow_core/test_worker.py`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Kubernetes worker service account values [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66598:
URL: https://github.com/apache/airflow/pull/66598#issuecomment-4407252183
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Kubernetes worker service account values [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66598:
URL: https://github.com/apache/airflow/pull/66598#issuecomment-4415864137
### Backport successfully created: chart/v1-2x-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>chart/v1-2x-test</td>
<td><a href="https://github.com/apache/airflow/pull/66661"><img src="https://img.shields.io/badge/PR-66661-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Kubernetes worker service account values [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #66598:
URL: https://github.com/apache/airflow/pull/66598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Kubernetes worker service account values [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #66598:
URL: https://github.com/apache/airflow/pull/66598#issuecomment-4409521750
Static checks requires fix tho, or revert as it failes on unrelated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Kubernetes worker service account values [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66598:
URL: https://github.com/apache/airflow/pull/66598#issuecomment-4415861597
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org