You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2017/08/17 07:29:00 UTC
[jira] [Comment Edited] (OAK-6407) Refactor oak.spi.query into a
separate module/bundle
[ https://issues.apache.org/jira/browse/OAK-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130044#comment-16130044 ]
angela edited comment on OAK-6407 at 8/17/17 7:28 AM:
------------------------------------------------------
[~tmueller], please don't do that! The whole exercise for cleaning up the mess between oak.spi.query and oak.query was that we can finally get rid of the bogus export for implementation details. I am totally opposed to reintroducing that export (so -1 :-)). Can you please try my original patch with the QueryEngineSettings in 'oak.spi.query'? That's how I managed to remove the troublesome exports. Thanks.
cc: [~mduerig], [~rombert]
was (Author: anchela):
[~tmueller], please don't do that! The whole exercise for cleaning up the mess between oak.spi.query and oak.query was that we can finally get rid of the bogus export for implementation details. I am totally opposed to reintroducing that export (so -1 :-)). Can you please try my original patch with the QueryEngineSettings in 'oak.spi.query'? That's how I managed to remove the troublesome export. Thanks.
cc: [~mduerig], [~rombert]
> Refactor oak.spi.query into a separate module/bundle
> ------------------------------------------------------
>
> Key: OAK-6407
> URL: https://issues.apache.org/jira/browse/OAK-6407
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, indexing, query
> Reporter: angela
> Assignee: Thomas Mueller
> Labels: modularization
> Fix For: 1.8
>
> Attachments: OAK-6407-b2.patch, OAK-6407-b.patch, OAK-6407.patch
>
>
> now that OAK-6304 and OAK-6355 have been resolved, i would like to suggest that we move the _o.a.j.oak.spi.query_ code base into a separate module/bundle in order to prevent the introduction of bogus cycles and odd package exports in the future.
> [~tmueller], patch will follow asap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)