You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (Created) (JIRA)" <ji...@apache.org> on 2011/12/18 08:41:34 UTC
[jira] [Created] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
-------------------------------------------------------------------------------------
Key: GIRAPH-106
URL: https://issues.apache.org/jira/browse/GIRAPH-106
Project: Giraph
Issue Type: Improvement
Reporter: Avery Ching
Assignee: Avery Ching
GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "Avery Ching (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-106:
-------------------------------
Attachment: GIRAPH-106.diff
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-106.diff
>
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172490#comment-13172490 ]
Hudson commented on GIRAPH-106:
-------------------------------
Integrated in Giraph-trunk-Commit #53 (See [https://builds.apache.org/job/Giraph-trunk-Commit/53/])
GIRAPH-106: Change prepareSuperstep() to make setMessages(Iterable<M>
messages) package-private. (aching)
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1220883
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-106.diff
>
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172351#comment-13172351 ]
jiraposter@reviews.apache.org commented on GIRAPH-106:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/#review3972
-----------------------------------------------------------
Ship it!
nice and simple!
- Sebastian
On 2011-12-19 08:25:55, Avery Ching wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3255/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-19 08:25:55)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added method assignMessagesToVertex() to bypass the package-private access for setMessages(). Cleaned up some missed formatting for GIRAPH-80 as well.
bq.
bq.
bq. This addresses bug GIRAPH-106.
bq. https://issues.apache.org/jira/browse/GIRAPH-106
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java 1220642
bq.
bq. Diff: https://reviews.apache.org/r/3255/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed local unittests.
bq.
bq.
bq. Thanks,
bq.
bq. Avery
bq.
bq.
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-106.diff
>
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172323#comment-13172323 ]
jiraposter@reviews.apache.org commented on GIRAPH-106:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/#review3971
-----------------------------------------------------------
Ship it!
Very simple, good work. +1
- Claudio
On 2011-12-19 08:25:55, Avery Ching wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3255/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-19 08:25:55)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added method assignMessagesToVertex() to bypass the package-private access for setMessages(). Cleaned up some missed formatting for GIRAPH-80 as well.
bq.
bq.
bq. This addresses bug GIRAPH-106.
bq. https://issues.apache.org/jira/browse/GIRAPH-106
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 1220642
bq. http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java 1220642
bq.
bq. Diff: https://reviews.apache.org/r/3255/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed local unittests.
bq.
bq.
bq. Thanks,
bq.
bq. Avery
bq.
bq.
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-106.diff
>
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172090#comment-13172090 ]
jiraposter@reviews.apache.org commented on GIRAPH-106:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3255/
-----------------------------------------------------------
Review request for giraph.
Summary
-------
Added method assignMessagesToVertex() to bypass the package-private access for setMessages(). Cleaned up some missed formatting for GIRAPH-80 as well.
This addresses bug GIRAPH-106.
https://issues.apache.org/jira/browse/GIRAPH-106
Diffs
-----
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 1220642
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/Vertex.java 1220642
Diff: https://reviews.apache.org/r/3255/diff
Testing
-------
Passed local unittests.
Thanks,
Avery
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-106) Refactor prepareSuperstep() to make
setMessages(Iterable messages) package-private
Posted by "Avery Ching (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching resolved GIRAPH-106.
--------------------------------
Resolution: Fixed
Thanks for the quick review guys.
> Refactor prepareSuperstep() to make setMessages(Iterable<M> messages) package-private
> -------------------------------------------------------------------------------------
>
> Key: GIRAPH-106
> URL: https://issues.apache.org/jira/browse/GIRAPH-106
> Project: Giraph
> Issue Type: Improvement
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-106.diff
>
>
> GIRAPH-80 revealed that there is some refactoring to make setMessages() package-private (prevent users from messing around with internals).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira