You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ja...@apache.org on 2018/02/14 19:37:39 UTC
[cordova-windows] branch janpio-msbuild_cleanup updated: fix eslint
This is an automated email from the ASF dual-hosted git repository.
janpio pushed a commit to branch janpio-msbuild_cleanup
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
The following commit(s) were added to refs/heads/janpio-msbuild_cleanup by this push:
new 691156a fix eslint
691156a is described below
commit 691156a3599f2af40d50c1ecb2d9d257e3718fc9
Author: Jan Piotrowski <pi...@gmail.com>
AuthorDate: Wed Feb 14 20:37:31 2018 +0100
fix eslint
---
template/cordova/lib/MSBuildTools.js | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/template/cordova/lib/MSBuildTools.js b/template/cordova/lib/MSBuildTools.js
index cc86d9f..b8f7ea5 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -143,12 +143,12 @@ function checkMSBuildVersion (version) {
// first, check if we have a VS 2017+ with such a version
var willows = module.exports.getWillowInstallations();
- //console.log('willows', willows);
+ // console.log('willows', willows);
var correspondingWillows = willows.filter(function (inst) {
- //console.log('willows.filter', inst.version, version, inst.version === version);
+ // console.log('willows.filter', inst.version, version, inst.version === version);
return inst.version === version;
});
- //console.log('correspondingWillows', correspondingWillows);
+ // console.log('correspondingWillows', correspondingWillows);
var correspondingWillow = correspondingWillows[0]; // TODO Do not only handle one!
if (correspondingWillow) {
version = '15.0';
@@ -157,7 +157,7 @@ function checkMSBuildVersion (version) {
console.log('from list of VS installations: ', correspondingWillows);
if (shell.test('-e', toolsPath)) {
var msbuild = module.exports.getMSBuildToolsAt(toolsPath);
- console.log('selected VS exists:', toolsPath, );
+ console.log('selected VS exists:', toolsPath);
// TODO check for JavaScript folder
return msbuild;
}
@@ -183,8 +183,6 @@ function checkMSBuildVersion (version) {
console.log('no registry result for version ' + version);
// if 'reg' exits with error, assume that registry key not found
});
-
- console.log('no msbuild found with version ', version);
}
module.exports.getLatestMatchingMSBuild = function (selectedBuildTargets) {
--
To stop receiving notification emails like this one, please contact
janpio@apache.org.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org