You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/12/21 14:05:38 UTC

Review Request 64771: AMBARI-22681 Ambari web UI failed to update stack repo directly from the Versions tab

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64771/
-----------------------------------------------------------

Review request for Ambari and Tim Thorpe.


Bugs: AMBARI-22681
    https://issues.apache.org/jira/browse/AMBARI-22681


Repository: ambari


Description
-------

REST API calls from the web got rejected by the ambari server with a missing property error.


Diffs
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 2f0cb68 
  ambari-web/app/utils/ajax/ajax.js 3f85dfdc 


Diff: https://reviews.apache.org/r/64771/diff/1/


Testing
-------

existing JS unit tests. Patch a trunk cluster with the changes and verify the UI now can save URLs without having to go to the admin view.


Thanks,

Di Li


Re: Review Request 64771: AMBARI-22681 Ambari web UI failed to update stack repo directly from the Versions tab

Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64771/#review194338
-----------------------------------------------------------


Ship it!




Ship It!

- Tim Thorpe


On Dec. 21, 2017, 2:05 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64771/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 2:05 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-22681
>     https://issues.apache.org/jira/browse/AMBARI-22681
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> REST API calls from the web got rejected by the ambari server with a missing property error.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 2f0cb68 
>   ambari-web/app/utils/ajax/ajax.js 3f85dfdc 
> 
> 
> Diff: https://reviews.apache.org/r/64771/diff/1/
> 
> 
> Testing
> -------
> 
> existing JS unit tests. Patch a trunk cluster with the changes and verify the UI now can save URLs without having to go to the admin view.
> 
> 
> Thanks,
> 
> Di Li
> 
>