You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2012/09/19 21:45:25 UTC

Review Request: [PIG-2908] Fix unit tests to work with jdk7

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7176/
-----------------------------------------------------------

Review request for pig.


Description
-------

Changes done:
Pig:
  - OrderedJunitRunner to run TestMRCompiler and TestLogToPhyCompiler as they depend on the order of tests to match the golden files. Removed extends TestCase as that does not work with a custom junit runner. 
  - Tests comparing physical plan had to be sorted as the hashmap.entrySet order is not guaranteed with jdk7.
  - JSonPropertyOrder had to be set to have json schema in a specified order. 

PiggyBank:
  - CSVExcelStorage was modifying a static field. Made it non-static
  - TestAvroStorage depended on a static field value. Set the field to expected value before test. 


This addresses bug PIG-2908.
    https://issues.apache.org/jira/browse/PIG-2908


Diffs
-----

  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/ResourceSchema.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestGFCross.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestJsonLoaderStorage.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMRCompiler.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMapSideCogroup.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMergeJoinOuter.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanLogToPhyTranslationVisitor.java 1387698 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/junit/OrderedJUnit4Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/7176/diff/


Testing
-------

This patch fixes tests


Thanks,

Rohini Palaniswamy

Re: Review Request: [PIG-2908] Fix unit tests to work with jdk7

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7176/
-----------------------------------------------------------

(Updated Oct. 3, 2012, 5:01 a.m.)


Review request for pig.


Changes
-------

Fix for few more test failures when run on RHEL6+JDK7 combination


Description
-------

Changes done:
Pig:
  - OrderedJunitRunner to run TestMRCompiler and TestLogToPhyCompiler as they depend on the order of tests to match the golden files. Removed extends TestCase as that does not work with a custom junit runner. 
  - Tests comparing physical plan had to be sorted as the hashmap.entrySet order is not guaranteed with jdk7.
  - JSonPropertyOrder had to be set to have json schema in a specified order. 

PiggyBank:
  - CSVExcelStorage was modifying a static field. Made it non-static
  - TestAvroStorage depended on a static field value. Set the field to expected value before test. 


This addresses bug PIG-2908.
    https://issues.apache.org/jira/browse/PIG-2908


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/pig/trunk/build.xml 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/CSVExcelStorage.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestPathPartitionHelper.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/TestPathPartitioner.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/ResourceSchema.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/data/SchemaTupleFrontend.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestGFCross.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestHBaseStorage.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestJobControlCompiler.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestJsonLoaderStorage.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestLogToPhyCompiler.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMRCompiler.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMapSideCogroup.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMergeJoinOuter.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanLogToPhyTranslationVisitor.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestScriptLanguage.java 1390773 
  http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/junit/OrderedJUnit4Runner.java PRE-CREATION 

Diff: https://reviews.apache.org/r/7176/diff/


Testing
-------

This patch fixes tests


Thanks,

Rohini Palaniswamy