You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/18 05:35:36 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2707: drivers: wireless: Fix ASSERT() in _read_data_len() in gs2200m.c

masayuki2009 commented on a change in pull request #2707:
URL: https://github.com/apache/incubator-nuttx/pull/2707#discussion_r559326176



##########
File path: drivers/wireless/gs2200m.c
##########
@@ -865,19 +865,19 @@ static uint16_t _read_data_len(FAR struct gs2200m_dev_s *dev)
 
   _write_data(dev, hdr, sizeof(hdr));
 
+  /* NOTE: busy wait 30us
+   * workaround to avoid an invalid frame response
+   */
+
+  up_udelay(30);

Review comment:
       >Can we use a sleep instead to not busy spin, or is this too fast?
   
   @btashton 
   Currently, Spresense uses a 10ms tick, so if we replace it with a sleep function, performance would be very bad.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org