You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by "edespino (via GitHub)" <gi...@apache.org> on 2025/10/27 00:57:24 UTC

[PR] Fix check-licenses script bugs [incubator-toree]

edespino opened a new pull request, #233:
URL: https://github.com/apache/incubator-toree/pull/233

   ## Summary
   This PR fixes two bugs in the `etc/tools/check-licenses` script that were discovered while reviewing Apache Toree 0.6.0-incubating RC1:
   
   1. **Removed unnecessary and buggy mkdir command (line 63)**: The `mkdir -p "$FWDIR"etc/tools/` command was both unnecessary and buggy. The `etc/tools` directory already exists in the repository (it contains the check-licenses script itself). Additionally, the command had a path concatenation bug with a missing `/` separator that would create a phantom directory like `toree-0.6.0-incubating-srcetc` in the parent directory.
   
   2. **Added target directory creation**: Added `mkdir -p target` before writing `target/rat-results.txt`. This ensures the script works when running `make auto-licenses` in a clean checkout without requiring a prior build to create the target directory.
   
   ## Test Plan
   - [ ] Verify no phantom directories are created when running the script
   - [ ] Test `make auto-licenses` in a clean checkout without prior build
   - [ ] Confirm rat-results.txt is successfully created in target directory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix check-licenses script bugs [incubator-toree]

Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende merged PR #233:
URL: https://github.com/apache/incubator-toree/pull/233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org