You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/15 14:59:49 UTC

[GitHub] [spark] srielau commented on a diff in pull request #36857: [SPARK-39470][SQL] Support cast of ANSI intervals to decimals

srielau commented on code in PR #36857:
URL: https://github.com/apache/spark/pull/36857#discussion_r898093995


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala:
##########
@@ -1015,6 +1014,11 @@ case class Cast(
       } catch {
         case _: NumberFormatException => null
       }
+    case x: DayTimeIntervalType =>
+      buildCast[Long](_, dt => changePrecision(dayTimeIntervalToDecimal(dt, x.endField), target))
+    case x: YearMonthIntervalType =>
+      buildCast[Int](_, ym =>
+        changePrecision(Decimal(yearMonthIntervalToInt(ym, x.startField, x.endField)), target))

Review Comment:
   I will take confusion on what is scale and what is precision to my grave....
   
   We can round/truncate, but not modulo/wrap.
   So I see:
   CAST(INTERVAL '1.234' SECOND AS DECIMAL(1,0)) as perfectly fine.
   But:
   CAST(INTERVAL('123.4' SECOND AS DECIMAL(4, 2)) is an overflow.
   On trunc vs round the semantic is given in DECIMAL to DECIMAL:
   select cast(1.5 AS DECIMAL(1, 0));
   2
   
   PS: I loathe that cannot change decimal precision error. In most cases we should just call it an overflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org