You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/26 11:43:38 UTC
[GitHub] [arrow] rok opened a new pull request, #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
rok opened a new pull request, #12997:
URL: https://github.com/apache/arrow/pull/12997
This is to resolve [ARROW-16173](https://issues.apache.org/jira/browse/ARROW-16173).
We want to benchmark temporal kernels to avoid performance regressions in future refactorings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1115347129
Benchmark runs are scheduled for baseline = e9481532e93e4f29a1c2c322e00f268d6cd9f534 and contender = 06ca00c2daeeb0d6461e7b6bec51679c19b5b92b. 06ca00c2daeeb0d6461e7b6bec51679c19b5b92b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d8726f95ce1c4e7cba49d45d65b873ef...e5025707be7c4adc8827f75151239de9/)
[Finished :arrow_down:0.12% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f7aa0ef67270499b90cb34207ecd623f...c2e852c480df4eb0bbb3ba47c6a1e264/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c30a8312aedd4a2d8a489b962153d72e...ecd9847724fe460aab23802d81219ac8/)
[Finished :arrow_down:0.16% :arrow_up:0.12%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/92dfa59ba3a3481aab7f039c582c4f63...d5d0c55d77d9429cbaa9b78002290351/)
Buildkite builds:
[Finished] [`06ca00c2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/646)
[Finished] [`06ca00c2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/643)
[Finished] [`06ca00c2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/634)
[Finished] [`06ca00c2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/648)
[Finished] [`e9481532` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/645)
[Finished] [`e9481532` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/642)
[Failed] [`e9481532` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/633)
[Finished] [`e9481532` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/647)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109754229
Supported benchmark command examples:
`@ursabot benchmark help`
To run all benchmarks:
`@ursabot please benchmark`
To filter benchmarks by language:
`@ursabot please benchmark lang=Python`
`@ursabot please benchmark lang=C++`
`@ursabot please benchmark lang=R`
`@ursabot please benchmark lang=Java`
`@ursabot please benchmark lang=JavaScript`
To filter Python and R benchmarks by name:
`@ursabot please benchmark name=file-write`
`@ursabot please benchmark name=file-write lang=Python`
`@ursabot please benchmark name=file-.*`
To filter C++ benchmarks by archery --suite-filter and --benchmark-filter:
`@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3`
For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109741171
Supported benchmark command examples:
`@ursabot benchmark help`
To run all benchmarks:
`@ursabot please benchmark`
To filter benchmarks by language:
`@ursabot please benchmark lang=Python`
`@ursabot please benchmark lang=C++`
`@ursabot please benchmark lang=R`
`@ursabot please benchmark lang=Java`
`@ursabot please benchmark lang=JavaScript`
To filter Python and R benchmarks by name:
`@ursabot please benchmark name=file-write`
`@ursabot please benchmark name=file-write lang=Python`
`@ursabot please benchmark name=file-.*`
To filter C++ benchmarks by archery --suite-filter and --benchmark-filter:
`@ursabot please benchmark command=cpp-micro --suite-filter=arrow-compute-vector-selection-benchmark --benchmark-filter=TakeStringRandomIndicesWithNulls/262144/2 --iterations=3`
For other `command=cpp-micro` options, please see https://github.com/ursacomputing/benchmarks/blob/main/benchmarks/cpp_micro_benchmarks.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109754853
@ursabot please benchmark command=cpp-micro --suite-filter=scalar-temporal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109754212
@ursabot please benchmark lang=C++ --suite-filter=scalar-temporal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110035916
Thanks @lidavidm ! I've implemented your feedback.
@ElenaHenderson thanks for pointing me to the [correct conbench link](https://conbench.ursa.dev/runs/019c6f9cdd82415382280c89be122b58/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109713602
https://issues.apache.org/jira/browse/ARROW-16173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110134065
Decided to add `Strftime` and `Strptime` benchmarks as there are some open questions around these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1111371051
No worries, I'm happy this made it in pre-release.
I'll take a look with debugger tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a diff in pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on code in PR #12997:
URL: https://github.com/apache/arrow/pull/12997#discussion_r858633893
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, options, nullptr).status());
+ }
+
+ state.SetItemsProcessed(state.iterations() * array_size);
+}
+
+template <UnaryOp& Op, std::shared_ptr<DataType>& timestamp_type>
+static void BenchmarkTemporal(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, nullptr).status());
+ }
+
+ state.SetItemsProcessed(state.iterations() * array_size);
+}
+
+auto zoned = timestamp(TimeUnit::NANO, "Pacific/Marquesas");
+auto non_zoned = timestamp(TimeUnit::NANO);
+
+#define DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(OPTIONS) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, CeilTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, FloorTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, RoundTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, CeilTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, FloorTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, RoundTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs);
+
+#define DECLARE_TEMPORAL_BENCHMARKS(OP) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, non_zoned)->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, zoned)->Apply(SetArgs);
+
+#define DECLARE_TEMPORAL_BENCHMARKS_ZONED(OP) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, zoned)->Apply(SetArgs);
+
+// Temporal rounding benchmarks
+auto round_1_minute = RoundTemporalOptions(1, CalendarUnit::MINUTE);
+auto round_10_minute = RoundTemporalOptions(10, CalendarUnit::MINUTE);
+auto round_1_week = RoundTemporalOptions(1, CalendarUnit::WEEK);
+auto round_10_week = RoundTemporalOptions(10, CalendarUnit::WEEK);
+auto round_1_month = RoundTemporalOptions(1, CalendarUnit::MONTH);
+auto round_10_month = RoundTemporalOptions(10, CalendarUnit::MONTH);
+
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_minute);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_week);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_month);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_minute);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_week);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_month);
+
+// Temporal component extraction
+DECLARE_TEMPORAL_BENCHMARKS(Year);
+DECLARE_TEMPORAL_BENCHMARKS(IsLeapYear);
+DECLARE_TEMPORAL_BENCHMARKS(Month);
+DECLARE_TEMPORAL_BENCHMARKS(Day);
+DECLARE_TEMPORAL_BENCHMARKS(DayOfYear);
+DECLARE_TEMPORAL_BENCHMARKS_ZONED(IsDaylightSavings);
+DECLARE_TEMPORAL_BENCHMARKS(USYear);
+DECLARE_TEMPORAL_BENCHMARKS(ISOYear);
+DECLARE_TEMPORAL_BENCHMARKS(ISOWeek);
+DECLARE_TEMPORAL_BENCHMARKS(USWeek);
+DECLARE_TEMPORAL_BENCHMARKS(Quarter);
+DECLARE_TEMPORAL_BENCHMARKS(Hour);
+DECLARE_TEMPORAL_BENCHMARKS(Minute);
+DECLARE_TEMPORAL_BENCHMARKS(Second);
+DECLARE_TEMPORAL_BENCHMARKS(Millisecond);
+DECLARE_TEMPORAL_BENCHMARKS(Microsecond);
+DECLARE_TEMPORAL_BENCHMARKS(Nanosecond);
+DECLARE_TEMPORAL_BENCHMARKS(Subsecond);
Review Comment:
@lidavidm do you think this is an excessive amount of benchmarks or should we have more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1111359551
Ah, sorry for merging it early. Hmm, that seems more like a bug. Are you able to see things in the debugger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110134336
@ursabot please benchmark command=cpp-micro --suite-filter=scalar-temporal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a diff in pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on code in PR #12997:
URL: https://github.com/apache/arrow/pull/12997#discussion_r858949262
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, options, nullptr).status());
Review Comment:
Added inside the benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a diff in pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on code in PR #12997:
URL: https://github.com/apache/arrow/pull/12997#discussion_r858948941
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
Review Comment:
Ah yes, much nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #12997:
URL: https://github.com/apache/arrow/pull/12997#discussion_r858717880
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
Review Comment:
note I think you can do this with `Array::View` instead of having to do it manually
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, options, nullptr).status());
Review Comment:
Are the nullptrs ExecContexts? Maybe we can just declare one for use here?
##########
cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc:
##########
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <functional>
+
+#include "benchmark/benchmark.h"
+
+#include "arrow/compute/api_scalar.h"
+#include "arrow/compute/kernels/test_util.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/benchmark_util.h"
+
+namespace arrow {
+
+namespace compute {
+
+constexpr auto kSeed = 0x94378165;
+
+std::vector<int64_t> g_data_sizes = {kL2Size};
+static constexpr int64_t kInt64Min = -2000000000; // 1906-08-16 20:26:40
+static constexpr int64_t kInt64Max = 2000000000; // 2033-05-18 03:33:20
+
+void SetArgs(benchmark::internal::Benchmark* bench) {
+ for (const auto inverse_null_proportion : std::vector<ArgsType>({100, 0})) {
+ bench->Args({static_cast<ArgsType>(kL2Size), inverse_null_proportion});
+ }
+}
+
+using UnaryRoundingOp = Result<Datum>(const Datum&, const RoundTemporalOptions,
+ ExecContext*);
+using UnaryOp = Result<Datum>(const Datum&, ExecContext*);
+
+template <UnaryRoundingOp& Op, std::shared_ptr<DataType>& timestamp_type,
+ RoundTemporalOptions& options>
+static void BenchmarkTemporalRounding(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, options, nullptr).status());
+ }
+
+ state.SetItemsProcessed(state.iterations() * array_size);
+}
+
+template <UnaryOp& Op, std::shared_ptr<DataType>& timestamp_type>
+static void BenchmarkTemporal(benchmark::State& state) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
+
+ auto rand = random::RandomArrayGenerator(kSeed);
+ auto array = std::static_pointer_cast<NumericArray<Int64Type>>(
+ rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion));
+ auto timestamp_array = std::make_shared<NumericArray<TimestampType>>(
+ timestamp_type, array->length(), array->data()->buffers[1],
+ array->data()->buffers[0], array->null_count());
+
+ for (auto _ : state) {
+ ABORT_NOT_OK(Op(timestamp_array, nullptr).status());
+ }
+
+ state.SetItemsProcessed(state.iterations() * array_size);
+}
+
+auto zoned = timestamp(TimeUnit::NANO, "Pacific/Marquesas");
+auto non_zoned = timestamp(TimeUnit::NANO);
+
+#define DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(OPTIONS) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, CeilTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, FloorTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, RoundTemporal, zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, CeilTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, FloorTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporalRounding, RoundTemporal, non_zoned, OPTIONS) \
+ ->Apply(SetArgs);
+
+#define DECLARE_TEMPORAL_BENCHMARKS(OP) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, non_zoned)->Apply(SetArgs); \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, zoned)->Apply(SetArgs);
+
+#define DECLARE_TEMPORAL_BENCHMARKS_ZONED(OP) \
+ BENCHMARK_TEMPLATE(BenchmarkTemporal, OP, zoned)->Apply(SetArgs);
+
+// Temporal rounding benchmarks
+auto round_1_minute = RoundTemporalOptions(1, CalendarUnit::MINUTE);
+auto round_10_minute = RoundTemporalOptions(10, CalendarUnit::MINUTE);
+auto round_1_week = RoundTemporalOptions(1, CalendarUnit::WEEK);
+auto round_10_week = RoundTemporalOptions(10, CalendarUnit::WEEK);
+auto round_1_month = RoundTemporalOptions(1, CalendarUnit::MONTH);
+auto round_10_month = RoundTemporalOptions(10, CalendarUnit::MONTH);
+
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_minute);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_week);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_1_month);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_minute);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_week);
+DECLARE_TEMPORAL_ROUNDING_BENCHMARKS(round_10_month);
+
+// Temporal component extraction
+DECLARE_TEMPORAL_BENCHMARKS(Year);
+DECLARE_TEMPORAL_BENCHMARKS(IsLeapYear);
+DECLARE_TEMPORAL_BENCHMARKS(Month);
+DECLARE_TEMPORAL_BENCHMARKS(Day);
+DECLARE_TEMPORAL_BENCHMARKS(DayOfYear);
+DECLARE_TEMPORAL_BENCHMARKS_ZONED(IsDaylightSavings);
+DECLARE_TEMPORAL_BENCHMARKS(USYear);
+DECLARE_TEMPORAL_BENCHMARKS(ISOYear);
+DECLARE_TEMPORAL_BENCHMARKS(ISOWeek);
+DECLARE_TEMPORAL_BENCHMARKS(USWeek);
+DECLARE_TEMPORAL_BENCHMARKS(Quarter);
+DECLARE_TEMPORAL_BENCHMARKS(Hour);
+DECLARE_TEMPORAL_BENCHMARKS(Minute);
+DECLARE_TEMPORAL_BENCHMARKS(Second);
+DECLARE_TEMPORAL_BENCHMARKS(Millisecond);
+DECLARE_TEMPORAL_BENCHMARKS(Microsecond);
+DECLARE_TEMPORAL_BENCHMARKS(Nanosecond);
+DECLARE_TEMPORAL_BENCHMARKS(Subsecond);
Review Comment:
I think this is reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109728919
```
-------------------------------------------------------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
-------------------------------------------------------------------------------------------------------------------------------------------
<FloorTemporal, zoned, round_1_minute>/4194304/100 9120000 ns 9113104 ns 77 bytes_per_second=438.928M/s items_per_second=57.5312M/s null_percent=1 size=4.1943M
<FloorTemporal, zoned, round_1_minute>/4194304/0 8990453 ns 8987171 ns 76 bytes_per_second=445.079M/s items_per_second=58.3374M/s null_percent=0 size=4.1943M
<FloorTemporal, non_zoned, round_1_minute>/4194304/100 1394757 ns 1394190 ns 489 bytes_per_second=2.80181G/s items_per_second=376.052M/s null_percent=1 size=4.1943M
<FloorTemporal, non_zoned, round_1_minute>/4194304/0 1161323 ns 1161207 ns 605 bytes_per_second=3.36396G/s items_per_second=451.503M/s null_percent=0 size=4.1943M
<FloorTemporal, zoned, round_10_minute>/4194304/100 9731440 ns 9727625 ns 72 bytes_per_second=411.2M/s items_per_second=53.8968M/s null_percent=1 size=4.1943M
<FloorTemporal, zoned, round_10_minute>/4194304/0 9674381 ns 9668781 ns 73 bytes_per_second=413.703M/s items_per_second=54.2248M/s null_percent=0 size=4.1943M
<FloorTemporal, non_zoned, round_10_minute>/4194304/100 1536740 ns 1536208 ns 453 bytes_per_second=2.54279G/s items_per_second=341.287M/s null_percent=1 size=4.1943M
<FloorTemporal, non_zoned, round_10_minute>/4194304/0 1389038 ns 1387374 ns 530 bytes_per_second=2.81557G/s items_per_second=377.9M/s null_percent=0 size=4.1943M
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109741157
@ursabot please benchmark lang=C++ --benchmark-filter=Temporal --show-output=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110973524
Filed ARROW-16372 for the Python Travis failure and added the C++ failure to ARROW-15221.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
URL: https://github.com/apache/arrow/pull/12997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110134366
Benchmark runs are scheduled for baseline = 3e56a949c73168d789612a9022cdceae6088e2b7 and contender = 65d16ef7a7cc465d134008ff6d9da6940e2ffade. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Only ['lang', 'name'] filters are supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6d866dee69cd4a029476be90ccac10c0...d1ca92c501cf4cb08efa0a5b4283f8e1/)
[Skipped :warning: Only ['lang', 'name'] filters are supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f1f3940e825f4466934ff2b64003a3ce...5d3d4b3de5084d99b764f409b631b029/)
[Skipped :warning: Only ['lang', 'name'] filters are supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1fd49b7e01564f6a8a0a2d94d7df8a21...e78e2dcaca684ceb88cbd1545f6c1224/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0a85929184984ed29a833ec82982a6eb...c767186fa768440094b84e05aabe1491/)
Buildkite builds:
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/621| `65d16ef7` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/637| `3e56a949` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/625| `3e56a949` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/580| `3e56a949` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/617| `3e56a949` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1109754926
Benchmark runs are scheduled for baseline = 3e56a949c73168d789612a9022cdceae6088e2b7 and contender = 8406afc5e0f63f7d945197c2218b381f1dbae48d. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Only ['lang', 'name'] filters are supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6d866dee69cd4a029476be90ccac10c0...42ea73fd96ed45138f0caaabe11b965c/)
[Skipped :warning: Only ['lang', 'name'] filters are supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f1f3940e825f4466934ff2b64003a3ce...35beec9552ca4996a4527bd93770bdb0/)
[Skipped :warning: Only ['lang', 'name'] filters are supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1fd49b7e01564f6a8a0a2d94d7df8a21...603c1672133345b6b9c31c5bfa3a9dd3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0a85929184984ed29a833ec82982a6eb...019c6f9cdd82415382280c89be122b58/)
Buildkite builds:
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/618| `8406afc5` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/637| `3e56a949` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/625| `3e56a949` test-mac-arm>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/580| `3e56a949` ursa-i9-9960x>
[Scheduled] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/617| `3e56a949` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1110975509
Thanks Rok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12997: ARROW-16173: [C++] Add benchmarks for temporal functions/kernels
Posted by GitBox <gi...@apache.org>.
rok commented on PR #12997:
URL: https://github.com/apache/arrow/pull/12997#issuecomment-1111200446
I wanted to add `AssumeTimezone` kernel benchmark like:
```
static void BenchmarkISOCalendar(benchmark::State& state) {
RegressionArgs args(state);
ExecContext* ctx = default_exec_context();
const int64_t array_size = args.size / sizeof(int64_t);
auto rand = random::RandomArrayGenerator(kSeed);
auto array =
rand.Numeric<Int64Type>(array_size, kInt64Min, kInt64Max, args.null_proportion);
EXPECT_OK_AND_ASSIGN(auto timestamp_array, array->View(timestamp(TimeUnit::NANO)));
for (auto _ : state) {
ABORT_NOT_OK(ISOCalendar(timestamp_array, ctx).status());
}
state.SetItemsProcessed(state.iterations() * array_size);
}
BENCHMARK(BenchmarkISOCalendar)->Apply(SetArgs);
```
And got:
```
arrow-compute-scalar-temporal-benchmark(74236,0x1049e0580) malloc: Incorrect checksum for freed object 0x105204740: probably modified after being freed.
Corrupt value: 0x3
arrow-compute-scalar-temporal-benchmark(74236,0x1049e0580) malloc: *** set a breakpoint in malloc_error_break to debug
```
Which I assume is due to `ISOCalendar` output being a struct array. Any ideas how to get around it? It's not a big issue but would be nice to cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org