[GitHub] [iceberg] samredai commented on a change in pull request #4223: Docs: Clarify merge-on-read modes in docs for spark

[GitBox <gi...@apache.org>]

samredai commented on a change in pull request #4223:
URL: https://github.com/apache/iceberg/pull/4223#discussion_r816032103



##########
File path: docs/versioned/spark/spark-writes.md
##########
@@ -98,6 +98,11 @@ WHEN NOT MATCHED AND s.event_time > still_valid_threshold THEN INSERT (id, count
 
 Only one record in the source data can update any given row of the target table, or else an error will be thrown.
 
+!!! Note
+    By default Spark uses copy-on-write merge mode.
+    With spark-3.2 and onwards, iceberg supports merge-on-read mode.    
+    To use merge-on-read merge mode, need to set the table property `write.merge.mode` to "merge-on-read".

Review comment:
       grammar nit: "need to set the table property" can just say "set the table property". Same comment for the other note boxes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org