[GitHub] [arrow] westonpace commented on a diff in pull request #12689: ARROW-15515: [C++] Update ExecPlan example code and documentation with new options

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #12689:
URL: https://github.com/apache/arrow/pull/12689#discussion_r842229179


##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -176,6 +176,20 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public SinkNodeOptions {
   SortOptions sort_options;
 };
 
+/// \brief Adapt an Table as a sink node
+///
+/// obtains the output of a execution plan to
+/// a table pointer.

Review Comment:
   ```suggestion
   /// obtain the output of an execution plan to
   /// a table.
   ```



##########
docs/source/cpp/streaming_execution.rst:
##########
@@ -647,6 +649,25 @@ SelectK example:
 
 .. _stream_execution_scan_docs:
 
+``table_sink``
+----------------
+
+.. _stream_execution_table_sink_docs:
+
+The ``table_sink`` node provides the ability to take the output as an in-memory table. 
+This is much simpler to use than the other sink nodes provided by the streaming execution engine

Review Comment:
   ```suggestion
   The ``table_sink`` node provides the ability to receive the output as an in-memory table. 
   This is simpler to use than the other sink nodes provided by the streaming execution engine
   ```
   Optional, but this sounds slightly better.



##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -176,6 +176,20 @@ class ARROW_EXPORT OrderBySinkNodeOptions : public SinkNodeOptions {
   SortOptions sort_options;
 };
 
+/// \brief Adapt an Table as a sink node

Review Comment:
   ```suggestion
   /// \brief Adapt a Table as a sink node
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org