You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/03/07 18:05:08 UTC

[GitHub] merlimat commented on a change in pull request #1322: Use private impl for MessageId in c++ client

merlimat commented on a change in pull request #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172932307
 
 

 ##########
 File path: pulsar-client-cpp/lib/MessageId.cc
 ##########
 @@ -30,43 +29,51 @@
 
 namespace pulsar {
 
-MessageId::MessageId() : ledgerId_(-1), entryId_(-1), partition_(-1) {}
+class MessageIdImpl {
+   public:
+    MessageIdImpl() : ledgerId_(-1), entryId_(-1), partition_(-1), batchIndex_(-1) {}
 
 Review comment:
   But can we use c++11??? You guys tell me.. :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services