You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "valentinp17 (via GitHub)" <gi...@apache.org> on 2023/09/12 08:04:34 UTC
[GitHub] [spark] valentinp17 opened a new pull request, #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
valentinp17 opened a new pull request, #42884:
URL: https://github.com/apache/spark/pull/42884
### What changes were proposed in this pull request?
1) Add test for getTablesByType function to cover error class "UNSUPPORTED_FUNCTION_BY_HIVE_VERSION" added in PR https://github.com/apache/spark/pull/42706
2) Fix link to error guideline
### Why are the changes needed?
1) Test error class for getTablesByType().
2) Link to error guideline is outdated.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
./build/sbt "testOnly org.apache.spark.SparkThrowableSuite"
./build/sbt "sql/testOnly org.apache.spark.sql.hive.client.HiveShimSuites"
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on PR #42884:
URL: https://github.com/apache/spark/pull/42884#issuecomment-1722320412
@itholic Done!
But I mess up and made merge at first attempt. So I had to make force push rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1354082025
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
Review Comment:
This is removed by https://github.com/apache/spark/commit/3c84c229d167a6ab2857649e91fff6f0d57bb12c
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1326582226
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
Review Comment:
I don't think so
I tried writing "HiveShimSuite" familiar to "HiveClientSuit", and there are no additional recovery plans for it either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1326575472
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -9,7 +9,7 @@ Thanks for sending a pull request! Here are some tips for you:
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
- 'core/src/main/resources/error/README.md'.
+ 'common/utils/src/main/resources/error/README.md'.
Review Comment:
Agree, I will create a new Jira ticket and PR for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #42884:
URL: https://github.com/apache/spark/pull/42884#issuecomment-1720429390
Seems like the CI failure is not related to this change. Could you rebase to master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1322639012
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
Review Comment:
qq: isn't there any chance to fail creating table here??
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
+ }
+
+ test("getTablesByType") {
+ if (version >= "2.3") {
+ val managed = shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
+ val external = shim.getTablesByType(hive, "default", "table1", TableType.EXTERNAL_TABLE)
+
+ assert(managed === Seq("table1"))
+ assert(external === Seq.empty)
+ } else {
+ val e = intercept[SparkUnsupportedOperationException] {
+ shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
Review Comment:
Maybe do we need to test for `EXTERNAL_TABLE` as well?
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -9,7 +9,7 @@ Thanks for sending a pull request! Here are some tips for you:
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
- 'core/src/main/resources/error/README.md'.
+ 'common/utils/src/main/resources/error/README.md'.
Review Comment:
I think technically this should be in separate PR, but it's okay since it's a minor typo fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on PR #42884:
URL: https://github.com/apache/spark/pull/42884#issuecomment-1715211850
@itholic @MaxGekk @cxzl25 PTAL when you find some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1357562747
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
Review Comment:
Yeah we don't support them anymore after JDK upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1326576833
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
+ }
+
+ test("getTablesByType") {
+ if (version >= "2.3") {
+ val managed = shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
+ val external = shim.getTablesByType(hive, "default", "table1", TableType.EXTERNAL_TABLE)
+
+ assert(managed === Seq("table1"))
+ assert(external === Seq.empty)
+ } else {
+ val e = intercept[SparkUnsupportedOperationException] {
+ shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
Review Comment:
Added external table to test working versions and exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1326582226
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
Review Comment:
I don't think so
I tried writing "HiveShimSuite" familiar to "HiveClientSuite", and there are no additional recovery plans for it either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION` [spark]
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1375240258
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
Review Comment:
Done.
Deleted 0.12-1.2 versions and rebased to master.
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
Review Comment:
Done
Deleted 0.12-1.2 versions and rebased to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on a diff in pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on code in PR #42884:
URL: https://github.com/apache/spark/pull/42884#discussion_r1326576833
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveShimSuite.scala:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.client
+
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.metastore.TableType
+import org.apache.hadoop.hive.ql.metadata.{Hive, Table}
+import org.apache.hadoop.hive.ql.session.SessionState
+
+import org.apache.spark.SparkUnsupportedOperationException
+import org.apache.spark.sql.hive.client.HiveClientImpl.getHive
+import org.apache.spark.util.Utils
+
+class HiveShimSuite(version: String) extends HiveVersionSuite(version) {
+
+ private val shim = version match {
+ case "0.12" => new Shim_v0_12()
+ case "0.13" => new Shim_v0_13()
+ case "0.14" => new Shim_v0_14()
+ case "1.0" => new Shim_v1_0()
+ case "1.1" => new Shim_v1_1()
+ case "1.2" => new Shim_v1_2()
+ case "2.0" => new Shim_v2_0()
+ case "2.1" => new Shim_v2_1()
+ case "2.2" => new Shim_v2_2()
+ case "2.3" => new Shim_v2_3()
+ case "3.0" => new Shim_v3_0()
+ case "3.1" => new Shim_v3_1()
+ }
+
+ private def hive: Hive = {
+ val hiveConf = new HiveConf(classOf[SessionState])
+ lazy val warehousePath = Utils.createTempDir()
+
+ hiveConf.set("datanucleus.schema.autoCreateAll", "true")
+ hiveConf.set("hive.metastore.schema.verification", "false")
+ hiveConf.set("hive.metastore.warehouse.dir", warehousePath.toString)
+
+ getHive(hiveConf)
+ }
+
+ test("createTables") {
+ shim.createTable(hive, new Table("default", "table1"), ifNotExists = true)
+ }
+
+ test("getTablesByType") {
+ if (version >= "2.3") {
+ val managed = shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
+ val external = shim.getTablesByType(hive, "default", "table1", TableType.EXTERNAL_TABLE)
+
+ assert(managed === Seq("table1"))
+ assert(external === Seq.empty)
+ } else {
+ val e = intercept[SparkUnsupportedOperationException] {
+ shim.getTablesByType(hive, "default", "table1", TableType.MANAGED_TABLE)
Review Comment:
Added external table to test working versions and exception cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] valentinp17 commented on pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
Posted by "valentinp17 (via GitHub)" <gi...@apache.org>.
valentinp17 commented on PR #42884:
URL: https://github.com/apache/spark/pull/42884#issuecomment-1734200182
@dongjoon-hyun could you please take a look and help decide whether these tests should be added or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42884:
URL: https://github.com/apache/spark/pull/42884#issuecomment-1933156917
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42884: [SPARK-42304][FOLLOWUP][SQL] Add test for `GET_TABLES_BY_TYPE_UNSUPPORTED_BY_HIVE_VERSION`
URL: https://github.com/apache/spark/pull/42884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org