You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/02/06 00:48:00 UTC

[jira] [Commented] (GEODE-4572) SerializationRegistry::addType and similar functions should return std::shared_ptr

    [ https://issues.apache.org/jira/browse/GEODE-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353165#comment-16353165 ] 

ASF subversion and git services commented on GEODE-4572:
--------------------------------------------------------

Commit 6135f3b4cb6875b05de42207a333eefc4bc52c19 in geode-native's branch refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6135f3b ]

 GEODE-4572: Refactor createDeserialized with std::shared_ptr. (#204)




> SerializationRegistry::addType and similar functions should return std::shared_ptr
> ----------------------------------------------------------------------------------
>
>                 Key: GEODE-4572
>                 URL: https://issues.apache.org/jira/browse/GEODE-4572
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently these functions return a raw pointer. Returning a std::shared_ptr reduces the chance for memory leaks and improves performance given that all use cases resulted in the raw pointer being wrapped later in std::shared_ptr.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)