[GitHub] [pinot] KKcorps commented on pull request #9538: Improve primary key serialization performance

[GitBox <gi...@apache.org>]

KKcorps commented on PR #9538:
URL: https://github.com/apache/pinot/pull/9538#issuecomment-1270644247

   > > It won't be the same, but we are not persisting it anywhere so it is okay to be not backward compatible
   > 
   > Interesting, why are we converting it to bytes then? Where's the deserialization logic? If it's just for hashing (quickly scanning the code, it looks like that's what it's used for in some places) won't it be even faster to just compute the hash instead of serializing it to bytes and then computing the hash?
   
   Yes, it will be. We already support hashing for primary keys. But users want to avoid the hash due to collisions and hence serialize the key itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org