You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/19 07:48:16 UTC

[GitHub] [inlong] woofyzhao commented on a diff in pull request #6221: [INLONG-6220][Manager] Support query of DP cluster based on GroupId and protocol

woofyzhao commented on code in PR #6221:
URL: https://github.com/apache/inlong/pull/6221#discussion_r999060361


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongClient.java:
##########
@@ -224,6 +224,15 @@ static InlongClient create(String serviceUrl, ClientConfiguration configuration)
      */
     PageResult<ClusterNodeResponse> listNode(ClusterPageRequest request);
 
+    /**
+     * Get DP node info by groupId and protocol
+     *
+     * @param groupId inlong group id
+     * @param protocolType protocol type, such as: TCP,HTTP
+     * @return DP list
+     */
+    List<ClusterNodeResponse> listDPNode(String groupId, String protocolType);

Review Comment:
   would it be clearer to use the full name DataProxy instead of DP?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org