[GitHub] [superset] diegomedina248 commented on a diff in pull request #19938: fix(chart & table): make to allow highlight in case of numeric column

[GitBox <gi...@apache.org>]

diegomedina248 commented on code in PR #19938:
URL: https://github.com/apache/superset/pull/19938#discussion_r864069615


##########
superset-frontend/plugins/plugin-chart-table/src/Styles.tsx:
##########
@@ -71,7 +71,7 @@ export default styled.div`
       cursor: pointer;
     }
     td.dt-is-filter:hover {
-      background-color: ${theme.colors.secondary.light4};
+      background-color: ${theme.colors.secondary.light4} !important;

Review Comment:
   if this was working for non-integers, why do we need the important now?



##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -317,7 +317,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
   const getColumnConfigs = useCallback(
     (column: DataColumnMeta, i: number): ColumnWithLooseAccessor<D> => {
       const { key, label, isNumeric, dataType, isMetric, config = {} } = column;
-      const isFilter = !isNumeric && emitFilter;
+      const isFilter = emitFilter;

Review Comment:
   is this variable needed now? (meaning, can we use `emitFilter` directly?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org