You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Yuanbo Liu <li...@gmail.com> on 2017/02/14 02:59:32 UTC
Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/
-----------------------------------------------------------
Review request for Ambari and Di Li.
Repository: ambari
Description
-------
Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
Diff: https://reviews.apache.org/r/56636/diff/
Testing
-------
The test failure in https://issues.apache.org/jira/browse/AMBARI-19911.
Thanks,
Yuanbo Liu
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Yuanbo Liu <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/
-----------------------------------------------------------
(Updated Feb. 19, 2017, 3:11 a.m.)
Review request for Ambari and Di Li.
Bugs: AMBARI-19911
https://issues.apache.org/jira/browse/AMBARI-19911
Repository: ambari
Description
-------
Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
Diff: https://reviews.apache.org/r/56636/diff/
Testing
-------
The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
Thanks,
Yuanbo Liu
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Di Li <di...@ca.ibm.com>.
> On Feb. 14, 2017, 8 p.m., Di Li wrote:
> > Ship It!
pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=9e5c57e3e7ae4a8b3df51efcbddcdb97a1f7b398
Yuanbo, please close this rb request.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165564
-----------------------------------------------------------
On Feb. 19, 2017, 3:11 a.m., Yuanbo Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2017, 3:11 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Bugs: AMBARI-19911
> https://issues.apache.org/jira/browse/AMBARI-19911
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
>
> Diff: https://reviews.apache.org/r/56636/diff/
>
>
> Testing
> -------
>
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
>
>
> Thanks,
>
> Yuanbo Liu
>
>
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165564
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
>
> Diff: https://reviews.apache.org/r/56636/diff/
>
>
> Testing
> -------
>
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
>
>
> Thanks,
>
> Yuanbo Liu
>
>
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165552
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
>
> Diff: https://reviews.apache.org/r/56636/diff/
>
>
> Testing
> -------
>
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
>
>
> Thanks,
>
> Yuanbo Liu
>
>
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Di Li <di...@ca.ibm.com>.
> On Feb. 17, 2017, 1:46 p.m., Di Li wrote:
> > Hello Yuan Bo, Please add JIRA ID to the Bugs field and specify the proper branch for the fix.
nm branch, just the JIRA ID
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165935
-----------------------------------------------------------
On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
>
> Diff: https://reviews.apache.org/r/56636/diff/
>
>
> Testing
> -------
>
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
>
>
> Thanks,
>
> Yuanbo Liu
>
>
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165935
-----------------------------------------------------------
Hello Yuan Bo, Please add JIRA ID to the Bugs field and specify the proper branch for the fix.
- Di Li
On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 3 a.m.)
>
>
> Review request for Ambari and Di Li.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
>
> Diff: https://reviews.apache.org/r/56636/diff/
>
>
> Testing
> -------
>
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
>
>
> Thanks,
>
> Yuanbo Liu
>
>
Re: Review Request 56636: When yarn-site.xml is changed,
MapReduce related components should be required to restart
Posted by Yuanbo Liu <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 3 a.m.)
Review request for Ambari and Di Li.
Repository: ambari
Description
-------
Some properties in yarn-site.xml are used by MR components, such as "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml is modified.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 25e242b
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 14eae07
Diff: https://reviews.apache.org/r/56636/diff/
Testing (updated)
-------
The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not related.
Thanks,
Yuanbo Liu