You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/27 15:05:17 UTC
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6528: Added RP2040 Boards: Adafruit KB2040 and Adafruit Feather RP2040
acassis commented on code in PR #6528:
URL: https://github.com/apache/incubator-nuttx/pull/6528#discussion_r907485738
##########
boards/arm/rp2040/adafruit-feather/README.txt:
##########
@@ -0,0 +1,180 @@
+README
+======
+
+This directory contains the port of NuttX to the Adafruit Feather RP2040.
+See https://www.adafruit.com/product/4884 for information
+about Adafruit Feather RP2040.
+
+Currently only the following devices are supported.
+
+ Supported:
+ - UART (console port)
+ - GPIO 0 (UART0 TX) and GPIO 1 (UART0 RX) are used for the console.
+ - I2C
+ - SPI
+ - DMAC
+ - PWM
+ - USB device
+ - MSC, CDC/ACM serial and these composite device are supported.
+ - CDC/ACM serial device can be used for the console.
+ - PIO (RP2040 Programmable I/O)
+ - Flash ROM Boot
+ - SRAM Boot
+ - If Pico SDK is available, nuttx.uf2 file which can be used in
+ BOOTSEL mode will be created.
+ - BMP180 sensor at I2C0 (don't forget to define I2C0 GPIOs at "I2C0 GPIO pin assign" in Board Selection menu)
+ - INA219 sensor / module (don't forget to define I2C0 GPIOs at "I2C0 GPIO pin assign" in Board Selection menu)
+ - Pico Display Pack (ST7789 LCD)
+ - RGB leds and buttons are not supported yet.
+ - Pico Audio Pack (PCM5100A I2S DAC)
+ - I2S interface is realized by PIO.
+
+ Not supported:
+ - All other devices
+
+Installation
+============
+
+1. Download Raspberry Pi Pico SDK
+
Review Comment:
Please consider adding README.txt to nuttx/Documentation/ that will be available online, i.e.: https://nuttx.apache.org/docs/latest/platforms/xtensa/esp32s3/boards/esp32s3-eye/index.html
##########
boards/arm/rp2040/adafruit-kb2040/src/rp2040_appinit.c:
##########
@@ -0,0 +1,78 @@
+/****************************************************************************
+ * boards/arm/rp2040/adafruit-kb2040/src/rp2040_appinit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/board.h>
+
+#include "rp2040_pico.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#ifndef OK
+# define OK 0
+#endif
Review Comment:
ditto
##########
boards/arm/rp2040/adafruit-feather/src/rp2040_appinit.c:
##########
@@ -0,0 +1,78 @@
+/****************************************************************************
+ * boards/arm/rp2040/adafruit-feather/src/rp2040_appinit.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/board.h>
+
+#include "rp2040_pico.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+#ifndef OK
+# define OK 0
+#endif
Review Comment:
Please consider "#include <sys/types.h>" instead of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org